This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
WebRequest.DefaultWebProxy: Set doesn't work without a previous Get #22720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless we do an unnecessary Get() on WebRequest.DefaultWebProxy, any Set() done will not be honored. This is especially a problem on Linux, where DefaultWebProxy throws PlatformNotSupportedException(). This in turn breaks libraries like WindowsAzure.Storage which fail unless the Get() is called first and then WebRequest.DefaultWebProxy is set to null. This fix avoids the unnecessary Get() by setting the already initialized flag sent to the LazyInitializer.
|
The fix LGTM. Could you add a test for this as well? |
davidsh
suggested changes
Jul 28, 2017
|
Thanks for your contribution @arunjvs! I've sent you collaborator invite. Pro-tip: Disable all CoreFX repo notifications, otherwise you will be DoS'd by all of them ;) If you need more info about contributing to CoreFX repo, check out our docs (also linked from our main page) https://github.com/dotnet/corefx/wiki/New-contributor-Docs (feel free to update them as well - they are RW for everyone), or just ask ... we will be happy to answer. Thanks! |
|
@arunjvs, did you mean to close this? |
|
Sorry folks. Lost track of this in the weekend. No intention to close :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless we do an unnecessary Get() on WebRequest.DefaultWebProxy, any Set() done will not be honored.
This is especially a problem on Linux, where DefaultWebProxy throws PlatformNotSupportedException(). This in turn breaks libraries like WindowsAzure.Storage which fail unless the Get() is called first and then WebRequest.DefaultWebProxy is set to null.
This fix avoids the unnecessary Get() by setting the already initialized flag sent to the LazyInitializer.
@davidsh