Fix the remaining System.ConfigManager tests. #21006
Conversation
| } | ||
|
|
||
| [Fact] | ||
| [SkipOnTargetFramework(TargetFrameworkMonikers.UapAot,"Exception messages are different")] |
There was a problem hiding this comment.
Can you just take out the Assert.Equal(expectedException.Message, result.Message) in both cases instead? Then the rest of the test runs.
Although, i thought that the exception message would be blank for both cases, so it would be equal anyway,.
There was a problem hiding this comment.
Generally we don't look at exception messages so it's better to just fix the test that way
|
Tests are failing |
| { | ||
| var exe = Path.GetFileName(ThisApplicationPath); | ||
| return exe + ".config"; | ||
| return Assembly.GetEntryAssembly().GetName().Name + ".config"; |
There was a problem hiding this comment.
this should be + ".exe.config" to make the tests pass
There was a problem hiding this comment.
I need to see why ThisApplicationPath is different on AOT and core.Changing it to ".exe.config" fails in AOT.
|
Apparently netcore do not like the change , need to re-work on this |
|
@dotnet-bot test Innerloop netfx Windows_NT Release x64 Build and Test |
Fix the remaining System.ConfigManager tests. Commit migrated from dotnet/corefx@a79e39f
5 participants
Fix the TestUtil.ThisConfigFileName so it works on uap-aot and disable the rest of the tests.
@JeremyKuhne