This repository was archived by the owner on Jan 23, 2023. It is now read-only.
More serialization test fixes #20377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons and fixes a diagnosability issue in DataContractSerializer tests
|
CC @krwq @dotnet/corert-contrib |
shmao
reviewed
May 26, 2017
| Assert.StrictEqual(((SimpleKnownTypeValue)actual.SimpleTypeValue).StrProperty, "PropertyValue"); | ||
| } | ||
|
|
||
| [Fact] |
There was a problem hiding this comment.
@morganbr can you please mark these tests with [ActiveIssue] https://github.com/dotnet/corefx/issues/20361 instead of removing them? It would be a little easier for me to update the tests to test custom exception with these scenarios.
|
@dotnet-bot test Linux x64 Tests - Debug - Ubuntu.1404.Amd64.Open |
|
CI isn't restarting, but I've confirmed my changes didn't cause the failures. |
krwq
pushed a commit
to krwq/corefx
that referenced
this pull request
May 31, 2017
Removes a couple more tests that depend on ISerializable implementations and fixes a diagnosability issue in DataContractSerializer tests
krwq
pushed a commit
to krwq/corefx
that referenced
this pull request
Jun 1, 2017
Removes a couple more tests that depend on ISerializable implementations and fixes a diagnosability issue in DataContractSerializer tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a couple more tests that depend on ISerializable implementations and fixes a diagnosability issue in DataContractSerializer tests.
Progress toward #19119