This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Added TimeZone/TimeZoneInfo/TimeZoneNotFoundException members #11149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danmosemsft still waiting on CoreCLR dependencies update. The members from #10074 that couldn't be added are found in #11075 and #11169. |
hann013
force-pushed
the
t-hazhan/PortTimeZoneInfo
branch
from
893b37e
to
a63cea8
Compare
|
cc @danmosemsft @ellismg this should be good to go now. |
| } | ||
|
|
||
| [Fact] | ||
| public static void LibyaTimeZone_TimeZoneNotFoundException() |
There was a problem hiding this comment.
I would remove this test. Here's my thinking. If TimeZoneInfo.FindSystemTimeZoneById(s_strLibya) throws, this test isn't going to execute. The value this test provides is in ensuring the LibyaTimeZone test works as expected and in general we don't expect the exception to be thrown. We already have functional coverage from the test which catches Exception.
hann013
force-pushed
the
t-hazhan/PortTimeZoneInfo
branch
from
f926324
to
004d721
Compare
|
|
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…ZoneInfo Added TimeZone/TimeZoneInfo/TimeZoneNotFoundException members Commit migrated from dotnet/corefx@704fe01
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added TimeZone/TimeZoneInfo/TimeZoneNotFoundException members and tests, as per #10074 and to fix #7552