Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Specify --no-cache on restore #10016

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Specify --no-cache on restore #10016

merged 1 commit into from
Jul 12, 2016

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jul 12, 2016

This lets us publish a package and consume it immediately from our
builds.

Without this our CI clients were relying on an HTTP cache of our myget
feeds and failing when we updated projects or buildtools.

/cc @stephentoub @eerhardt

This lets us publish a package and consume it immediately from our
builds.

Without this our CI clients were relying on an HTTP cache of our myget
feeds and failing when we updated projects or buildtools.
@eerhardt
Copy link
Member

The change LGTM. But I question if this is really what we want to do... Is this 100% necessary? If the default "dotnet restore" options aren't good enough for us, maybe the product needs to change.

@ericstj
Copy link
Member Author

ericstj commented Jul 12, 2016

@eerhardt the product does support this. I'd say that most of the time you want to use the HTTP cache since it makes the restore quicker. Most of the time you aren't wanting to get packages that were published in the last few hours. It's only in our repo where we are doing a big sync up front where we don't care about the additional cost of going to the network to get the latest packages.
It does seem like NuGet should refresh it's cache if it can't find an exact version match, I'll file an issue on that.

@ericstj
Copy link
Member Author

ericstj commented Jul 12, 2016

NuGet issue: NuGet/Home#3116

@ericstj ericstj merged commit 04dc5f3 into dotnet:master Jul 12, 2016
StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this pull request Jul 22, 2016
* Synccing shared files between WCF and CoreFx, most of the changes are part of the following CoreFx PRs...
   dotnet/corefx#10045
   dotnet/corefx#9971
   dotnet/corefx#10221
   dotnet/corefx#10016
   dotnet/corefx#9974
@ericstj ericstj deleted the restoreNoCache branch September 27, 2016 22:38
@karelz karelz modified the milestone: 1.1.0 Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants