Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Commit

Permalink
Call base class implementation instead of explicitly throwing
Browse files Browse the repository at this point in the history
  • Loading branch information
0xced committed Jul 12, 2018
1 parent 1a44a35 commit ffc8014
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo c
return new Version(version.Major, version.Minor, version.Build, version.Revision); // return new instance
}

throw GetConvertFromException(value);
return base.ConvertFrom(context, culture, value);
}

/// <summary>
Expand All @@ -72,7 +72,7 @@ public override object ConvertTo(ITypeDescriptorContext context, CultureInfo cul
return new Version(version.Major, version.Minor, version.Build, version.Revision);
}

throw GetConvertToException(value, destinationType);
return base.ConvertTo(context, culture, value, destinationType);
}

public override bool IsValid(ITypeDescriptorContext context, object value)
Expand Down

0 comments on commit ffc8014

Please sign in to comment.