Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Commit

Permalink
Fix package testing issue by reverting the inbox version of System.Te…
Browse files Browse the repository at this point in the history 
…xt.Json in netcoreapp3.1
  • Loading branch information
@joperezr
joperezr committed Mar 17, 2020
1 parent e97f7a2 commit bca12a5
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
8 changes: 8 additions & 0 deletions pkg/Microsoft.Private.CoreFx.NETCoreApp/Microsoft.Private.CoreFx.NETCoreApp.pkgproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@
System.ComponentModel.Composition;
</Value>
</ValidatePackageSuppression>
<!-- Permit inbox revsion of assemblies that are part of shared framework but also ship as packages. This will

This comment has been minimized.

Sign in to view

Copy link
@ericstj

ericstj Mar 17, 2020 •
edited
Loading

Member

Why was this required? Can you please share the error message you were getting?

This comment has been minimized.

Sign in to view

Copy link
@joperezr

joperezr Mar 17, 2020

Author Member

The private transport package was failing due to a version inconsistency, System.Text.Json was expected to be inbox with version 4.0.1.0 but was found to have 4.0.1.1. Here is the error message I got:

C:\Users\joperezr\.nuget\packages\microsoft.dotnet.build.tasks.packaging\1.0.0-beta.20113.5\build\Packaging.targets(1161,5): error : File System.Text.Json, version 4.0.1.1 was included framework package Microsoft.Private.CoreFx.NETCoreApp/4.7.0-dev.20167.1 but that version is not considered inbox in package index F:\git\corefx\pkg\Microsoft.Private.PackageBaseline\packageIndex.json.  Please add it with appropriate InboxOn entry for netcoreapp3.1 or suppress this message with PermitInbox suppression. [F:\git\corefx\pkg\Microsoft.Private.CoreFx.NETCoreApp\Microsoft.Private.CoreFx.NETCoreApp.pkgproj]
make sure other packages that have a reference to them will carry a package reference to the latest serviced
version. -->
<ValidatePackageSuppression Include="PermitInbox">
<Value>
System.Text.Json;
</Value>
</ValidatePackageSuppression>
</ItemGroup>

<Target Name="VerifyRuntimeOnlyFilesArePresentOnAllRuntimePackages"
Expand Down
8 changes: 6 additions & 2 deletions pkg/Microsoft.Private.PackageBaseline/packageIndex.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2993,6 +2993,9 @@
}
},
"System.Net.Http.Json": {
"StableVersions": [

This comment has been minimized.

Sign in to view

Copy link
@ericstj

ericstj Mar 17, 2020

Member

This needs to be removed. It should not be stable

This comment has been minimized.

Sign in to view

Copy link
@joperezr

joperezr Mar 17, 2020

Author Member

Yes sorry, I actually did remove this and ammended the commit.
"3.2.0"
],
"InboxOn": {},
"AssemblyVersionInPackageVersion": {
"3.2.0.0": "3.2.0"
Expand Down Expand Up @@ -4194,7 +4197,8 @@
"4.5.1",
"4.5.2",
"4.6.0",
"4.7.0"
"4.7.0",
"4.7.1"
],
"BaselineVersion": "4.7.0",
"InboxOn": {
Expand Down Expand Up @@ -5540,7 +5544,7 @@
"BaselineVersion": "4.7.0",
"InboxOn": {
"netcoreapp3.0": "4.0.0.0",
"netcoreapp3.1": "4.0.1.1",
"netcoreapp3.1": "4.0.1.0",
"uap10.0.16300": "4.0.1.0"
},
"AssemblyVersionInPackageVersion": {
Expand Down

0 comments on commit bca12a5

Please sign in to comment.