Updated removedItems to use an array instead of a List<T>

dotnet · Mar 11, 2019 · 91cf013 · 91cf013
1 parent 91eb11d
commit 91cf013
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/src/System.ObjectModel/src/System/Collections/ObjectModel/ObservableCollection.cs b/src/System.ObjectModel/src/System/Collections/ObjectModel/ObservableCollection.cs
@@ -146,10 +146,17 @@ protected override void RemoveItemsRange(int index, int count)
                 length = index + count;
             }
 
-            List<T> removedItems = new List<T>();
-            for (int i = index; i < length; i++)
+            T[] oldItems = new T[Items.Count];
+            if (Items is List<T> list)
             {
-                removedItems.Add(this[i]);
+                list.CopyTo(oldItems);
+            }
+            else
+            {
+                for (int i = 0; i < oldItems.Length; i++)
+                {
+                    oldItems[i] = this[i];
+                }
             }
 
             bool ignore = _skipRaisingEvents;
@@ -172,6 +179,12 @@ protected override void RemoveItemsRange(int index, int count)
 
             if (count > 0 && !_skipRaisingEvents)
             {
+                T[] removedItems = new T[count];
+                for (int i = 0; i < count; i++)
+                {
+                    removedItems[i] = oldItems[index + i];
+                }
+
                 OnCountPropertyChanged();
                 OnIndexerPropertyChanged();
                 OnCollectionChanged(NotifyCollectionChangedAction.Remove, removedItems, index);