This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
CollectionsMarshal.AsSpan allow null refs #26903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Sep 26, 2019
tannergooding
approved these changes
Sep 26, 2019
ahsonkhan
approved these changes
Sep 26, 2019
|
Lol, race condition. Usually "approves" post-merge don't show up: |
We can quickly revisit this in the next review and also close on us not adding |
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Sep 26, 2019
Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Sep 26, 2019
Signed-off-by: dotnet-bot <[email protected]>
marek-safar
pushed a commit
to mono/mono
that referenced
this pull request
Sep 26, 2019
Signed-off-by: dotnet-bot <[email protected]>
ViktorHofer
pushed a commit
to dotnet/corefx
that referenced
this pull request
Sep 26, 2019
) Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Sep 26, 2019
Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Sep 27, 2019
Signed-off-by: dotnet-bot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #26867 (comment)
@jkotas @GrabYourPitchforks @ahsonkhan @tannergooding does this change require api review?