This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Merged
Conversation
A recent change has incorrectly added dependency on libcoreclrpal.a to libutilcodenohost.a. This in turn, due to the transitive propagation of dependencies, caused the libmscordbi to be linked with libcoreclrpal.a. So libmscordbi contained its own PAL after that change, which is wrong. libmscordbi should depend on PAL APIs through libmscordaccore that exports the symbols it needs for it in order to keep just one PAL in the process. The fix is to remove the libcoreclrpal.a dependency and export few new symbols from libmscordaccore instead.
hoyosjs
approved these changes
Apr 12, 2019
gregg-miskelly
approved these changes
Apr 12, 2019
Member
|
Test failures are #23941 |
davmason
pushed a commit
to davmason/coreclr
that referenced
this pull request
Apr 27, 2019
A recent change has incorrectly added dependency on libcoreclrpal.a to libutilcodenohost.a. This in turn, due to the transitive propagation of dependencies, caused the libmscordbi to be linked with libcoreclrpal.a. So libmscordbi contained its own PAL after that change, which is wrong. libmscordbi should depend on PAL APIs through libmscordaccore that exports the symbols it needs for it in order to keep just one PAL in the process. The fix is to remove the libcoreclrpal.a dependency and export few new symbols from libmscordaccore instead.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
A recent change has incorrectly added dependency on libcoreclrpal.a to libutilcodenohost.a. This in turn, due to the transitive propagation of dependencies, caused the libmscordbi to be linked with libcoreclrpal.a. So libmscordbi contained its own PAL after that change, which is wrong. libmscordbi should depend on PAL APIs through libmscordaccore that exports the symbols it needs for it in order to keep just one PAL in the process. The fix is to remove the libcoreclrpal.a dependency and export few new symbols from libmscordaccore instead. Commit migrated from dotnet/coreclr@2573e4e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change has incorrectly added dependency on libcoreclrpal.a to
libutilcodenohost.a. This in turn, due to the transitive propagation of
dependencies, caused the libmscordbi to be linked with libcoreclrpal.a.
So libmscordbi contained its own PAL after that change, which is wrong.
libmscordbi should depend on PAL APIs through libmscordaccore that
exports the symbols it needs for it in order to keep just one PAL in the
process.
The fix is to remove the libcoreclrpal.a dependency and export few
new symbols from libmscordaccore instead.