Remove dlclose call to unload CoreCLR

[nxtn]

@jkotas commented 2 years ago in https://github.com/dotnet/coreclr/issues/12266#issuecomment-308484006

Yes, the dlclose call should be removed.

Is that still true?

[jkotas]

Thank you!

[nxtn]

Completely unrelated to this PR, you shouldn't use three different naming of CoreCLR, even in one file.

coreclr/src/coreclr/hosts/unixcoreruncommon/coreruncommon.cpp

Lines 356 to 359 in 448e39d

	void* coreclrLib = dlopen(coreClrDllPath.c_str(), RTLD_NOW | RTLD_LOCAL);
	if (coreclrLib != nullptr)
	{
	coreclr_initialize_ptr initializeCoreCLR = (coreclr_initialize_ptr)dlsym(coreclrLib, "coreclr_initialize");

Could you standardize the naming? I suggest using CoreClr or coreClr, except for the Unix style APIs.

[jkotas]

I believe that the two most widely used forms are CoreCLR and coreclr. If you would like to submit a PR to clean it up, I would recommend to stick with these two. Also, the coreclr prefixes and suffixes in this file are not always helpful - they can be just removed in some cases (e.g. when they are used for names of locals).

[nxtn]

Should these calls to FreeLibrary also be removed?

coreclr/src/coreclr/hosts/corerun/corerun.cpp

Line 160 in 448e39d

::FreeLibrary(m_coreCLRModule);

coreclr/src/coreclr/hosts/coreconsole/coreconsole.cpp

Line 184 in 448e39d

::FreeLibrary(m_coreCLRModule);

[jkotas]

Yes, these can be deleted as well.