This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix GetFullAffinityMask for cpuCount==64#23276
Merged
jkotas merged 2 commits intodotnet:masterfrom Mar 15, 2019
Merged
Conversation
The function was incorrectly assuming that shifting 64 bit constant 1 by 64 bits to the left gets result 0.
Member
Author
|
cc: @vkvenkat |
jkotas
reviewed
Mar 15, 2019
src/gc/unix/gcenv.unix.cpp
Outdated
| { | ||
| return ((uintptr_t)1 << (cpuCount)) - 1; | ||
| assert((cpuCount > 0) && (cpuCount <= sizeof(uintptr_t) * 8)); | ||
| return (((uintptr_t)1 << (cpuCount - 1)) << 1) - 1; |
Member
There was a problem hiding this comment.
It is not obvious why the shift is split into two parts. It can use a comment.
Also, it may be better for readability to just use if (cpuCount >= sizeof(uintptr_t) * 8) ....
sergiy-k
approved these changes
Mar 15, 2019
jkotas
approved these changes
Mar 15, 2019
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
The function was incorrectly assuming that shifting 64 bit constant 1 by 64 bits to the left gets result 0. Commit migrated from dotnet/coreclr@6600932
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function was incorrectly assuming that shifting 64 bit
constant 1 by 64 bits to the left gets result 0.