This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
don't use r2r images when the profiler requests that ngen images are disabled #13349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jkotas can you or someone appropriate please review this? I see it's not reviewed. |
|
If it's reviewed, I believe it can be merged. |
jkotas
approved these changes
Aug 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes so that ready to run images are not loaded when a profiler requests that NGEN images are not used, or when a profiler requests that profiled NGEN images are used.
Conceptually profilers don't care if pre-generated images are NGEN or R2R. When they request that native images are not loaded, it is because the profiler wants to have all functions be instrumentable.