Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API diff between .NET 9 RC1 and .NET 9 RC 2 #9539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Oct 8, 2024

Repo area owners:

Libraries area owners:

Known api-diff tool issues:

If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:

``` diff
namespace System.Reflection.Emit {
public sealed class PersistedAssemblyBuilder : AssemblyBuilder {
- public override bool IsDynamic { get; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflection.Emit change looks good

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STJ changes LGTM

@ericstj
Copy link
Member Author

ericstj commented Oct 10, 2024

@JeremyKuhne can I get your check of the WindowsDesktop changes?

@ericstj
Copy link
Member Author

ericstj commented Oct 10, 2024

@carlossanlop does this look good to you, anything we need to do manually to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants