-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update markdown formatting #9369
Conversation
There is a strange artifact in https://raw.githubusercontent.com/dotnet/core/8a0d0c9577d9f6d864411e85b16e54d390eacc83/release-notes/7.0/supported-os.md Looks a bit like the file was shorter and wrote into an existing older variant. We might want to ensure it's truncated on opening in the generator. |
@richlander let me know if those linux links are okay https://developer.android.com/about/versions/pie is legit so we are fine to merge if the other updates I did are good |
I am going to make a couple more changes. |
@richlander Shouldn‘t the links in the JSON be changed as well? As this is where those originated from. core/release-notes/6.0/supported-os.json Line 41 in 18130e5
|
Can you elaborate? I'm not following. |
I understand now. I missed that @jamesmontemagno changed the markdown. I'll fix that in another one PR. Thanks for noticed that. |
Yes, it seems that you reverted his changes by regenerating. He seemed to have fixed some links. And the Linux support would need to be fixed in the templates before regenerating. |
The Apple links don't seem better to me. They don't relate to an OS version. What was your thinking on that @jamesmontemagno ? |
https://support.apple.com/ios/ goes to a random article on how to install it trying to align with the other ones for macos and apple-tv... there isn't a lifecycle though |
No description provided.