Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to supported-os.json files #9367

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Conversation

richlander
Copy link
Member

@richlander richlander commented Jun 25, 2024

Dependent on #9294 and waiting on json files to be published to the specified URLs.

Context: #9370

@@ -12,7 +12,8 @@
"support-phase": "preview",
"eol-date": "2026-05-11",
"release-type" : "sts",
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/9.0/releases.json"
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/9.0/releases.json",
"supported-os.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/9.0/suported-os.json"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches. Fixed the typos.

I'm waiting on the files to be published to blog storage before merging this PR. I suspect it will be soon.

@leecow

"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/8.0/releases.json"
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/8.0/releases.json",
"supported-os.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/8.0/supported-os.json"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Remove empty line.

"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/7.0/releases.json"
"releases.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/7.0/releases.json",
"supported-os.json": "https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/7.0/supported-os.json"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Remove empty line.

@richlander
Copy link
Member Author

Just ran "format document" and a json linter on the document. That resolved the existing feedback. I see that the markdown files are live on dotnetcli.blob.core.windows.net. Thanks @leecow!

Will these files now get updated on a monthly schedule on blob storage?

@richlander richlander merged commit 559fd95 into main Jul 10, 2024
2 checks passed
@richlander richlander deleted the release-index-supported-os branch July 10, 2024 00:33
@leecow
Copy link
Member

leecow commented Jul 10, 2024

Will these files now get updated on a monthly schedule on blob storage?

Yes, should be good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants