API diff between .NET 9 Preview1 and .NET 9 Preview2 #9220
Conversation
.../9.0/preview/preview2/api-diff/Microsoft.NETCore.App/9.0-preview2_System.Net.Http.Headers.md
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,13 @@ | |||
| # System.Numerics | |||
| @@ -0,0 +1,374 @@ | |||
| # System.Runtime.Intrinsics.Arm | |||
There was a problem hiding this comment.
System.Runtime.Intrinsics.Arm LGTM
| @@ -0,0 +1,86 @@ | |||
| # System.Runtime.Intrinsics.X86 | |||
There was a problem hiding this comment.
System.Runtime.Intrinsics.X86 LGTM
| @@ -0,0 +1,31 @@ | |||
| # System.Runtime.Intrinsics | |||
There was a problem hiding this comment.
System.Runtime.Intrinsics LGTM
| + public static byte CompareExchange(ref byte location1, byte value, byte comparand); | ||
| + public static short CompareExchange(ref short location1, short value, short comparand); | ||
| + public static sbyte CompareExchange(ref sbyte location1, sbyte value, sbyte comparand); | ||
| + public static ushort CompareExchange(ref ushort location1, ushort value, ushort comparand); | ||
| + public static byte Exchange(ref byte location1, byte value); | ||
| + public static short Exchange(ref short location1, short value); | ||
| + public static sbyte Exchange(ref sbyte location1, sbyte value); | ||
| + public static ushort Exchange(ref ushort location1, ushort value); |
There was a problem hiding this comment.
The unsigned overloads have an [System.CLSCompliantAttribute(false)] attribute on them, should that also be shown here? LGTM otherwise.
There was a problem hiding this comment.
If the attribute was freshly added or removed, it should've showed up in the diff. Was that the case?
These are the only attributes I'm explicitly excluding (by request from past api diff PRs):
https://github.com/carlossanlop/arcade/blob/AsmDiffUpdates/src/Microsoft.DotNet.AsmDiff/AttributesToExclude.txt
I opened this issue to track the request: dotnet/arcade#14585
There was a problem hiding this comment.
It looks like the APIs were added along with the attribute.
| - public struct JsonReaderState | ||
| + public readonly struct JsonReaderState | ||
| public sealed class JsonSerializerOptions { | ||
| + public bool AllowOutOfOrderMetadataProperties { get; set; } |
| ``` diff | ||
| namespace System.IO { | ||
| public class FileStream : Stream { | ||
| + public override void CopyTo(Stream destination, int bufferSize); |
There was a problem hiding this comment.
This is not new, the last time it was touched was 3 years ago:
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
[Insert moral philosophy joke here]
Repo area owners:
Libraries area owners:
Known api-diff tool issues:
If yo usee any of these, please provide a GitHub suggestion in this PR to correct it:
{or{}arcade#10981([AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API arcade#13814)protected internalvisibility should stop showing. AsmDiff: Do not show APIs withprotected internalvisibility arcade#14579