Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API diff between .NET 8 RC2 and .NET 8 GA #8919

Merged
merged 4 commits into from
Nov 27, 2023
Merged

API diff between .NET 8 RC2 and .NET 8 GA #8919

merged 4 commits into from
Nov 27, 2023

Conversation

carlossanlop
Copy link
Member

Known tooling issues:

  • The AsmDiff tool sometimes skips adding { or {}. Please provide a GitHub suggestion in this PR so I can correct it. arcade#10981
  • The AsmDiff tool shows APIs with decorating attribute changes as removed and re-added, instead of showing only the API. Please ignore this, it might be confusing but technically it's not incorrect. I have an issue to track this: arcade#13814

Repos area owners:

Libraries area owners:

  • System.Numerics: @dotnet/area-system-numerics

@carlossanlop carlossanlop self-assigned this Nov 15, 2023
tannergooding
tannergooding reviewed Nov 15, 2023
View reviewed changes
release-notes/8.0/preview/api-diff/ga/Microsoft.NETCore.App/8.0-ga_System.Numerics.md
@@ -0,0 +1,44 @@
# System.Numerics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlossanlop carlossanlop merged commit 9cadcea into dotnet:main Nov 27, 2023
3 checks passed
@carlossanlop carlossanlop deleted the ApiDiffGA branch November 27, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannergooding tannergooding tannergooding left review comments

@rbhanda rbhanda Awaiting requested review from rbhanda rbhanda is a code owner

@leecow leecow Awaiting requested review from leecow leecow is a code owner

Assignees

@carlossanlop carlossanlop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlossanlop @tannergooding