API diff between .NET 8.0 Preview 3 and .NET 8 Preview 4 #8469

carlossanlop · 2023-05-18T17:52:33Z

ASP.NET - @dotnet/aspnet-api-review
WinForms - @merriemcgaw @dreddy-work @JeremyKuhne
WPF - @singhashish-wpf and @pchaurasia14
Libraries - @jeffhandley @karelz @ericstj @stephentoub
Microsoft.CSharp: @cston @333fred
Microsoft.VisualBasic: @cston @333fred
System.CodeDom: @dotnet/area-system-codedom
System.Collections: @dotnet/area-system-collections
System.ComponentModel.DataAnnotations: @dotnet/area-system-componentmodel-dataannotations
System.ComponentModel: @dotnet/area-system-componentmodel
System.Data: @ajcvickers @DavoudEshtehari @David-Engel @roji
System.Diagnostics.Tracing: @noahfalk @tommcdon @tarekgh
System.Formats.Asn1: @dotnet/area-system-formats-asn1
System.Globalization: @dotnet/area-system-globalization
@System.IO: @dotnet/area-system-io
System.Net: @dotnet/ncl
System.Numerics: @dotnet/area-system-numerics
System.Reflection: @dotnet/area-system-reflection
System.Reflection.Metadata: @dotnet/area-system-reflection-metadata
System.Resources: @dotnet/area-system-resources
System.Runtime: @dotnet/area-system-runtime
System.Runtime.CompilerServices: @dotnet/area-system-runtime-compilerservices
System.Runtime.InteropServices: @dotnet/interop-contrib
System.Runtime.Intrinsics: @dotnet/area-system-runtime-intrinsics
System.Security: @dotnet/area-system-security
System.Text.Json: @dotnet/area-system-text-json
System.Text: @dotnet/area-system-text-encoding
System.Text.RegularExpressions: @dotnet/area-system-text-regularexpressions
System.Threading: @mangod9 @kouvel
System.Threading.Channels: @dotnet/area-system-threading-channels
System.Threading.Tasks: @dotnet/area-system-threading-tasks
System.Transactions: @GrabYourPitchforks (not owner but made the changes)
System.Xml: @dotnet/area-system-xml
System: @dotnet/area-system-runtime

...f/preview4/Microsoft.AspNetCore.App/8.0-preview4_Microsoft.AspNetCore.Components.Sections.md

...otes/8.0/preview/api-diff/preview4/Microsoft.WindowsDesktop.App/8.0-preview4_System.Media.md

...eview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.InteropServices.md

...eview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_Microsoft.CSharp.RuntimeBinder.md

...preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_Microsoft.VisualBasic.FileIO.md

tannergooding · 2023-05-18T19:21:31Z

...se-notes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Numerics.md

@@ -0,0 +1,13 @@
+# System.Numerics


System.Numerics changes LGTM

CC. @dotnet/area-system-numerics

...view/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.CompilerServices.md

tannergooding · 2023-05-18T19:22:57Z

...review/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.Intrinsics.Arm.md

@@ -0,0 +1,35 @@
+# System.Runtime.Intrinsics.Arm


System.Runtime.Intrinsics.Arm changes LGTM

CC. @dotnet/area-system-runtime-intrinsics, @kunalspathak

tannergooding · 2023-05-18T19:24:01Z

...eview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.Intrinsics.Wasm.md

@@ -0,0 +1,166 @@
+# System.Runtime.Intrinsics.Wasm


System.Runtime.Intrinsics.Wasm changes LGTM

CC. @dotnet/area-system-runtime-intrinsics

@radekdoulik, are these "on by default" now or is there still work before that happens?

tannergooding · 2023-05-18T19:25:12Z

...review/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.Intrinsics.X86.md

@@ -0,0 +1,582 @@
+# System.Runtime.Intrinsics.X86


System.Runtime.Intrinsics.X86 LGTM

CC. @dotnet/area-system-runtime-intrinsics, @dotnet/avx512-contrib

tannergooding · 2023-05-18T19:27:45Z

...s/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Threading.Tasks.md

@@ -0,0 +1,28 @@
+# System.Threading.Tasks


System.Threading.Tasks LGTM.

cc. @dotnet/area-system-threading-tasks, @stephentoub

The serialization diffs on the last two APIs have the same question as https://github.com/dotnet/core/pull/8469/files#r1198216476 on if anything changed in the tooling here.

tannergooding · 2023-05-18T19:29:22Z

release-notes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.md

@@ -0,0 +1,331 @@
+# System


System.Runtime changes LGTM.

CC. @dotnet/area-system-runtime

The serialization diffs on the various APIs have the same question as https://github.com/dotnet/core/pull/8469/files#r1198216476 on if anything changed in the tooling here.

The main issue was the inability of the tool to generate the diff for new attributes, particularly the obsolete attribute. It should be fixed now.

...tes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Globalization.md

tarekgh · 2023-05-18T21:03:04Z

release-notes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.md

+        public DateTimeOffset GetLocalNow();
+        public virtual long GetTimestamp();
+        public virtual DateTimeOffset GetUtcNow();
+    }


tarekgh · 2023-05-18T21:04:04Z

...s/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Threading.Tasks.md

+     public class Task<TResult> : Task {
+        public new Task<TResult> WaitAsync(TimeSpan timeout, TimeProvider timeProvider);
+        public new Task<TResult> WaitAsync(TimeSpan timeout, TimeProvider timeProvider, CancellationToken cancellationToken);
+     }


tarekgh · 2023-05-18T21:04:53Z

...tes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Globalization.md

+     public enum NumberStyles {
+        AllowBinarySpecifier = 1024,
+        BinaryNumber = 1027,
+     }


tarekgh · 2023-05-18T21:06:19Z

Globalization and the parts in System and Tasks related to TimeProvider LGTM.

adamsitnik

System.IO* and the new Ascii APIs LGTM, but the exceptions ctors got obsoleted (not added) and this requires a change.

adamsitnik · 2023-05-19T10:03:58Z

release-notes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.IO.md

+
+``` diff
+ namespace System.IO {
+     public class DirectoryNotFoundException : IOException {


these ctors got obsoleted, not added: dotnet/runtime#84383

The ObsoleteAttribute is now showing up. Please ignore the slightly weird formatting. At least it makes sense now.

It looks better now, but I wonder if it could be improved: no + or - for the ctor itself, just mention the ctor with no prefx (no diff), and two new lines (+) for the attributes?

+ [EditorBrowsableAttribute(EditorBrowsableState.Never)] + [ObsoleteAttribute("This API supports obsolete formatter-based serialization. It should not be called or extended by application code.", DiagnosticId="SYSLIB0051", UrlFormat="https://aka.ms/dotnet-warnings/{0}")] protected DirectoryNotFoundException(SerializationInfo info, StreamingContext context);

I agree it would be nice to show such diffs as you describe. However, adding changes to the AsmDiff tool is time consuming and I currently cannot address it. If you don't mind, I'll merge this PR with the addressed fixes and will open an issue in the arcade repo to consider your suggestion.

dotnet/arcade#13814

carlossanlop · 2023-05-22T18:38:37Z

@BrennanConroy @tarekgh @tannergooding @adamsitnik @tommcdon @cston I fixed the weird diffs related to attributes. Would you mind taking a look again?

...f/preview4/Microsoft.AspNetCore.App/8.0-preview4_Microsoft.AspNetCore.Components.Sections.md

stephentoub · 2023-05-22T18:44:40Z

...preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_Microsoft.VisualBasic.FileIO.md

+-        protected MalformedLineException(SerializationInfo info, StreamingContext context);
+        [EditorBrowsableAttribute(EditorBrowsableState.Never)]
+        [ObsoleteAttribute("This API supports obsolete formatter-based serialization. It should not be called or extended by application code.", DiagnosticId="SYSLIB0051", UrlFormat="https://aka.ms/dotnet-warnings/{0}")]
+        protected MalformedLineException(SerializationInfo info, StreamingContext context);


In the future, could we render these differently? Right now it looks like we deleted an API and added an API, when this could instead just show an addition for the two new attributes.

I agree the output is ugly. Unfortunately, fixing AsmDiff is very low priority right now. It takes a lot of my time to fix it since the code is difficult to maintain and the project has no tests. I am hoping we can eventually move to using GenAPI instead of Microsoft.Cci for generating these API diffs, that would help a lot. I can't promise anything in the short term, but I'll keep this in mind.

For reference, I have a PR out here to fix the attribute problem reported in other comments: dotnet/arcade#13641

stephentoub · 2023-05-22T18:48:28Z

...eview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Text.RegularExpressions.md

+-    public abstract class RegexRunnerFactory
+    [EditorBrowsableAttribute(EditorBrowsableState.Never)]
+    public abstract class RegexRunnerFactory
+ }


stephentoub · 2023-05-22T18:48:40Z

...otes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Text.Unicode.md

+            public bool AppendFormatted<T>(T value, string? format);
+            public bool AppendLiteral(string value);
+        }
+     }


System.Text.Unicode LGTM

dreddy-work · 2023-05-22T18:56:45Z

...es/8.0/preview/api-diff/preview4/Microsoft.WindowsDesktop.App/8.0-preview4_System.Drawing.md

+        DesktopPC = 94,
+        DeviceAudioPlayer = 102,
+        DeviceCamera = 100,
+        DeviceCellPhone = 99,


System.Drawing* and WinForms LGTM.

cston · 2023-05-22T19:09:51Z

...preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_Microsoft.VisualBasic.FileIO.md

+        [ObsoleteAttribute("This API supports obsolete formatter-based serialization. It should not be called or extended by application code.", DiagnosticId="SYSLIB0051", UrlFormat="https://aka.ms/dotnet-warnings/{0}")]
+        public override void GetObjectData(SerializationInfo info, StreamingContext context);
+     }
+ }


}

Microsoft.CSharp and Microsoft.VisualBasic LGTM.

adamsitnik

The System.IO LGTM now, I left a comment with an idea for further simplification.

adamsitnik · 2023-05-23T06:50:02Z

release-notes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.IO.md

+
+``` diff
+ namespace System.IO {
+     public class DirectoryNotFoundException : IOException {


It looks better now, but I wonder if it could be improved: no + or - for the ctor itself, just mention the ctor with no prefx (no diff), and two new lines (+) for the attributes?

+ [EditorBrowsableAttribute(EditorBrowsableState.Never)] + [ObsoleteAttribute("This API supports obsolete formatter-based serialization. It should not be called or extended by application code.", DiagnosticId="SYSLIB0051", UrlFormat="https://aka.ms/dotnet-warnings/{0}")] protected DirectoryNotFoundException(SerializationInfo info, StreamingContext context);

Co-authored-by: Brennan <[email protected]>

carlossanlop added 5 commits May 18, 2023 10:36

Fix scripts

00af17b

Microsoft.AspNetCore.App

3b87ff7

Microsoft.NETCore.App

c7bdc30

Microsoft.WindowsDesktop.App

a30f2e2

Add base README

8f398ad

carlossanlop self-assigned this May 18, 2023

carlossanlop requested review from rbhanda and leecow as code owners May 18, 2023 17:52

BrennanConroy reviewed May 18, 2023

View reviewed changes

...f/preview4/Microsoft.AspNetCore.App/8.0-preview4_Microsoft.AspNetCore.Components.Sections.md Outdated Show resolved Hide resolved

danmoseley reviewed May 18, 2023

View reviewed changes

...otes/8.0/preview/api-diff/preview4/Microsoft.WindowsDesktop.App/8.0-preview4_System.Media.md Outdated Show resolved Hide resolved

AaronRobinsonMSFT reviewed May 18, 2023

View reviewed changes

...eview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.InteropServices.md Outdated Show resolved Hide resolved

AaronRobinsonMSFT reviewed May 18, 2023

View reviewed changes

...eview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.InteropServices.md Outdated Show resolved Hide resolved

AaronRobinsonMSFT reviewed May 18, 2023

View reviewed changes

...eview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.InteropServices.md Outdated Show resolved Hide resolved

cston reviewed May 18, 2023

View reviewed changes

...eview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_Microsoft.CSharp.RuntimeBinder.md Show resolved Hide resolved

cston reviewed May 18, 2023

View reviewed changes

...preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_Microsoft.VisualBasic.FileIO.md Show resolved Hide resolved

tannergooding reviewed May 18, 2023

View reviewed changes

...view/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Runtime.CompilerServices.md Outdated Show resolved Hide resolved

tannergooding reviewed May 18, 2023

View reviewed changes

tarekgh reviewed May 18, 2023

View reviewed changes

...tes/8.0/preview/api-diff/preview4/Microsoft.NETCore.App/8.0-preview4_System.Globalization.md Outdated Show resolved Hide resolved

tarekgh reviewed May 18, 2023

View reviewed changes

adamsitnik requested changes May 19, 2023

View reviewed changes

carlossanlop added 2 commits May 22, 2023 11:35

Microsoft.AspNetCore.App: Fix missing attributes.

36f7e0f

Microsoft.NETCore.App: Fix missing attributes.

c3a42d7

Microsoft.WindowsDesktop.App: Fix missing attributes.

9155ec9

BrennanConroy reviewed May 22, 2023

View reviewed changes

...f/preview4/Microsoft.AspNetCore.App/8.0-preview4_Microsoft.AspNetCore.Components.Sections.md Outdated Show resolved Hide resolved

stephentoub reviewed May 22, 2023

View reviewed changes

dreddy-work reviewed May 22, 2023

View reviewed changes

cston reviewed May 22, 2023

View reviewed changes

adamsitnik approved these changes May 23, 2023

View reviewed changes

Apply suggestions from code review

c0da143

Co-authored-by: Brennan <[email protected]>

carlossanlop mentioned this pull request Jun 15, 2023

[AsmDiff] For attributes, move the +/- diff symbol to the attribute instead of the affected API dotnet/arcade#13814

Open

carlossanlop merged commit b548bbc into dotnet:main Jun 15, 2023

carlossanlop deleted the ApiDiffPreview4 branch June 15, 2023 02:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

API diff between .NET 8.0 Preview 3 and .NET 8 Preview 4 #8469

API diff between .NET 8.0 Preview 3 and .NET 8 Preview 4 #8469

carlossanlop commented May 18, 2023

tannergooding May 18, 2023

tannergooding May 18, 2023

tannergooding May 18, 2023

tannergooding May 18, 2023

tannergooding May 18, 2023

tannergooding May 18, 2023

tannergooding May 18, 2023 •

edited

Loading

tannergooding May 18, 2023

tannergooding May 18, 2023

carlossanlop Jun 15, 2023

tarekgh May 18, 2023

tarekgh May 18, 2023

tarekgh May 18, 2023

tarekgh commented May 18, 2023

adamsitnik left a comment

adamsitnik May 19, 2023

carlossanlop May 22, 2023

adamsitnik May 23, 2023

carlossanlop Jun 15, 2023

carlossanlop Jun 15, 2023

carlossanlop commented May 22, 2023

stephentoub May 22, 2023

carlossanlop May 22, 2023

carlossanlop May 22, 2023 •

edited

Loading

stephentoub May 22, 2023

stephentoub May 22, 2023

dreddy-work May 22, 2023

cston May 22, 2023

adamsitnik left a comment

adamsitnik May 23, 2023

API diff between .NET 8.0 Preview 3 and .NET 8 Preview 4 #8469

API diff between .NET 8.0 Preview 3 and .NET 8 Preview 4 #8469

Conversation

carlossanlop commented May 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tannergooding May 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarekgh commented May 18, 2023

adamsitnik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlossanlop commented May 22, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlossanlop May 22, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adamsitnik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tannergooding May 18, 2023 •

edited

Loading

carlossanlop May 22, 2023 •

edited

Loading