Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support statement about old target frameworks #8305

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

richlander
Copy link
Member

No description provided.

@@ -47,6 +47,8 @@ Patches are published at the [.NET Website](https://dotnet.microsoft.com/downloa

As the end of support nears for a given .NET version, we strongly recommend you move to a newer, supported version of .NET. .NET releases that have reached end of support do not get security patches. Continuing to use an unsupported version will expose you to security vulnerabilities.

End of support also applies to source that targets unsupported .NET versions. You must target a supported .NET version (via the `TargetFramework` property), for both apps and libraries. The .NET SDK produces warnings when you target out of support versions to help identify these cases. The SDK does not prevent you from targeting unsupported versions, however, your configuration will be considered unsupported.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must target a supported .NET version (via the TargetFramework property), for both apps and libraries

This is incorrect. We specifically support targeting old TF in libraries.

Copy link
Member

@terrajobst terrajobst Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must target a supported .NET version (via the TargetFramework property), for both apps and libraries.

Just to add to that, we have specifically given 1P partner guidance to no waste their time upgrading .NET Framework/.NET Core versions in library projects and told them that upgrading application/services/unit tests is what they should focus on.

Also, it just doesn't make sense to say "all versions of .NET Standard are supported to target in perpetuity" and simultaneously say that targeting the frameworks that implement them from the same projects is unsupported.

Copy link
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not reflect the reality of what we support.

Copy link
Member

@terrajobst terrajobst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the same was @jaredpar.

We should scope it to apps, not libraries.

@@ -47,6 +47,8 @@ Patches are published at the [.NET Website](https://dotnet.microsoft.com/downloa

As the end of support nears for a given .NET version, we strongly recommend you move to a newer, supported version of .NET. .NET releases that have reached end of support do not get security patches. Continuing to use an unsupported version will expose you to security vulnerabilities.

End of support also applies to source that targets unsupported .NET versions. You must target a supported .NET version (via the `TargetFramework` property), for both apps and libraries. The .NET SDK produces warnings when you target out of support versions to help identify these cases. The SDK does not prevent you from targeting unsupported versions, however, your configuration will be considered unsupported.
Copy link
Member

@terrajobst terrajobst Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must target a supported .NET version (via the TargetFramework property), for both apps and libraries.

Just to add to that, we have specifically given 1P partner guidance to no waste their time upgrading .NET Framework/.NET Core versions in library projects and told them that upgrading application/services/unit tests is what they should focus on.

Also, it just doesn't make sense to say "all versions of .NET Standard are supported to target in perpetuity" and simultaneously say that targeting the frameworks that implement them from the same projects is unsupported.

@jkotas
Copy link
Member

jkotas commented Mar 20, 2023

it just doesn't make sense to say "all versions of .NET Standard are supported to target in perpetuity" and simultaneously say that targeting the frameworks that implement them from the same projects is unsupported.

It may not make sense to you, but it is where we are today given that we are including source generators as part of netcoreapp targeting pack.

@jkotas
Copy link
Member

jkotas commented Mar 20, 2023

we have specifically given 1P partner guidance to no waste their time upgrading .NET Framework/.NET Core versions in library projects and told them that upgrading application/services/unit tests is what they should focus on.

Yes, our guidance is to focus on upgrading the applications first. If we have guidance that targeting old .NET Core versions is supported forever for libraries, we either need to fix the guidance, or fix how we compose and service the product to be compatible with that guidance.

@richlander richlander closed this Feb 5, 2024
@richlander richlander deleted the source-support branch February 5, 2024 22:08
@jaredpar jaredpar restored the source-support branch February 13, 2024 23:24
@jaredpar jaredpar reopened this Feb 13, 2024
@richlander richlander merged commit 08f8ff1 into main Feb 14, 2024
1 of 2 checks passed
@richlander richlander deleted the source-support branch February 14, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants