add api diff for preview5 #6330
Conversation
| ``` diff | ||
| namespace Microsoft.Win32.SafeHandles { | ||
| + public abstract class SafeNCryptHandle : SafeHandleZeroOrMinusOneIsInvalid { | ||
| + protected SafeNCryptHandle(); |
There was a problem hiding this comment.
What's new here? Most of this stuff previously existed.
There was a problem hiding this comment.
It seems like we added openssl and cng dlls to the ref pack cc @ericstj @ViktorHofer
There was a problem hiding this comment.
There was a problem hiding this comment.
The implementation was in the shared framework already, but the reference assembly was OOB because of single-platform support. Now that we have the platform analyzer stuff we got rid of the package, so this is probably showing up as being "new in the shared framework reference API set"
There was a problem hiding this comment.
If we have a reasonable way of leaving all of the SafeNCrypt*Handle types out, I think that'd be best. It's not "new API" so much as "we changed some layout".
There was a problem hiding this comment.
yeah i can go ahead and remove them.
| ``` diff | ||
| namespace System.Numerics { | ||
| - public struct Complex : IEquatable<Complex>, IFormattable | ||
| + public readonly struct Complex : IEquatable<Complex>, IFormattable |
There was a problem hiding this comment.
Changes to Complex and Vector LGTM.
CC. @pgovind
| ``` diff | ||
| namespace System.Runtime.CompilerServices { | ||
| public static class RuntimeFeature { | ||
| + public const string VirtualStaticsInInterfaces = "VirtualStaticsInInterfaces"; |
There was a problem hiding this comment.
CC. @jeffhandley that this made Preview 5 for the generic-math work.
There was a problem hiding this comment.
Ah awesome, I didn't realize this went it already!
...6.0/preview/api-diff/preview5/.Net/6.0-preview5_System.Runtime.InteropServices.ObjectiveC.md
Show resolved
Hide resolved
|
|
||
| ``` diff | ||
| namespace System.Runtime.Versioning { | ||
| + public sealed class RequiresPreviewFeaturesAttribute : Attribute { |
There was a problem hiding this comment.
RequiresPreviewFeaturesAttribute LGTM.
CC. @pgovind
|
System.Diagnostics looks good to me. |
| + public void Encrypt(ReadOnlySpan<byte> nonce, ReadOnlySpan<byte> plaintext, Span<byte> ciphertext, Span<byte> tag, ReadOnlySpan<byte> associatedData = default(ReadOnlySpan<byte>)); | ||
| + } | ||
| + public sealed class CngAlgorithm : IEquatable<CngAlgorithm> { | ||
| + public CngAlgorithm(string algorithm); |
There was a problem hiding this comment.
Same question here... hasn't a lot of this stuff previously existed?
There was a problem hiding this comment.
It seems like we added openssl and cng dlls to the ref pack cc @ericstj @ViktorHofer
There was a problem hiding this comment.
Ideally, System.Security.Cryptography wouldn't show any of the Cng or OpenSsl types as a diff (as with the SafeHandles).
I'd expect to just see
- AesCcm.IsSupported
- AesGcm.IsSupported
- ChaCha20Poly1305 (the type and all its members)
| ``` diff | ||
| namespace System { | ||
| public abstract class Array : ICloneable, ICollection, IEnumerable, IList, IStructuralComparable, IStructuralEquatable { | ||
| + public static int MaxLength { get; } |
There was a problem hiding this comment.
Array.MaxLength addition LGTM. CC. @pgovind
| # System.Text.Json.Node | ||
|
|
||
| ``` diff | ||
| -namespace System.Text.Json.Node { |
There was a problem hiding this comment.
Would it be possible/better for this to show up as a change in namespace name rather than massive deletion / addition of everything in the namespace?
There was a problem hiding this comment.
i can think of a trivial way to automatically detect this. But i can create an issue in arcade to see if we can do this.
https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.AsmDiff most of the core code base is similar to this (in case u r interested)
|
|
||
| ``` diff | ||
| namespace Microsoft.AspNetCore.Authentication.Cookies { | ||
| public interface ITicketStore { |
...ase-notes/6.0/preview/api-diff/preview5/Asp.Net/6.0-preview5_Microsoft.AspNetCore.Builder.md
Show resolved
Hide resolved
| # Microsoft.AspNetCore.Connections | ||
|
|
||
| ``` diff | ||
| namespace Microsoft.AspNetCore.Connections { |
| ``` diff | ||
| namespace Microsoft.AspNetCore.Http.Connections { | ||
| public class HttpConnectionDispatcherOptions { | ||
| + public TimeSpan TransportSendTimeout { get; set; } |
| # Microsoft.AspNetCore.Http | ||
|
|
||
| ``` diff | ||
| namespace Microsoft.AspNetCore.Http { |
There was a problem hiding this comment.
@shirhatti This needs a good call out with examples in the blog post!
|
|
||
| ``` diff | ||
| namespace Microsoft.Extensions.DependencyInjection { | ||
| + public readonly struct AsyncServiceScope : IAsyncDisposable, IDisposable, IServiceScope { |
|
@bartonjs I removed the extra stuff, can you take a look ? |
cc @adamsitnik @carlossanlop @jozkee @eiriktsarpalis @layomia @buyaa-n @joperezr @krwq @kouvel @pgovind @tannergooding @steveharter @tarekgh @dotnet/ncl
@stephentoub @ericstj @danmoseley
cc @pranavkm @Tratcher @Pilchie @davidfowl @dougbu @richlander