Skip to content

Remove resx-in-subfolder known issue #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vivmishra merged 2 commits into from
Sep 30, 2019
Merged

Remove resx-in-subfolder known issue #3471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62fd260
Remove resx-in-subfolder known issue
rainersigwald Sep 25, 2019
67957e9
Mark preview issue as resolved
rainersigwald Sep 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions release-notes/3.0/3.0-known-issues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@ This document lists known issues for **.NET Core 3.0 GA and beyond releases** wh
</PropertyGroup>
```

- **Builds fail with `MSB3041` when a `.resx` file is in a subfolder [microsoft/msbuild#4695](https://github.com/microsoft/msbuild/issues/4695)**

MSBuild incorrectly constructs paths to `DependentUpon` source files related to `.resx` files that aren't at the project root. There is a workaround:

Explicitly set `DependentUpon` metadata for resource files ([example for Entity Framework migrations](https://github.com/aspnet/EntityFramework6/issues/1225#issuecomment-528571274)).

### Preview 5

- **Visual style in WinForms app not showing correctly when publishing with PublishReadyToRun=true**
Expand Down
4 changes: 3 additions & 1 deletion release-notes/3.0/preview/3.0.0-preview-known-issues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ This document lists known issues for **.NET Core 3.0 Preview releases** which ma

### Preview 9

- **Misnamed or colliding non-resx resources ([microsoft/msbuild#4740](https://github.com/microsoft/msbuild/issues/4740))**
- **[RESOLVED] Misnamed or colliding non-resx resources ([microsoft/msbuild#4740](https://github.com/microsoft/msbuild/issues/4740))**

Projects that specify non-resx `EmbeddedResource`s may have the resources embedded under an incorrect name (causing code that uses the correct name to fail at runtime). If two or more files are embedded in this way, `CS1508: The resource identifier ... has already been used in this assembly` may be issued at build time.

Expand All @@ -31,6 +31,8 @@ This document lists known issues for **.NET Core 3.0 Preview releases** which ma
<EmbeddedResourceUseDependentUponConvention>false</EmbeddedResourceUseDependentUponConvention>
</PropertyGroup>
```

Resolved in the final `3.0.100` SDK.

- **Builds fail with `MSB3041` when a `.resx` file is in a subfolder [microsoft/msbuild#4695](https://github.com/microsoft/msbuild/issues/4695)**

Expand Down