This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.0-preview9] Fix bundle installer signing #7822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This OrderProjectReference is unnecessary: ensuring the MSI files are signed before bundling them is already handled by the infrastructure in the GetBundledMsiFiles target.
MichaelSimons
approved these changes
Aug 23, 2019
mmitche
approved these changes
Aug 23, 2019
|
I ran another validation real-signed build with this branch in particular, and results are good: https://dev.azure.com/dnceng/internal/_build/results?buildId=322481. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7817. The bundle installers fail to install with
0x80070001 - Incorrect function. The most likely direct cause of that error is the burn engine not being signed. There are several MSBuild authoring problems related to signing that this PR fixes: runtime MSIs are not signed due to a build order issue, and the burn bundle engine is not reattached to the bundle installer.A validation real-signed build shows that this PR resolves the issue: https://github.com/dotnet/core-setup/issues/7817#issuecomment-524388499.
Clean cherry-pick of #7820 to
release/3.0-preview9.Customer Impact
The .NET Core Runtime and Windows Desktop Runtime bundle installers currently fail to install, with a cryptic error message.
Regression?
Yes, the .NET Core Runtime bundle installer in particular. The changes made to produce the Windows Desktop Runtime bundle inadvertently caused this problem for both bundle installers.
Risk
Low. The authoring errors are simple to correct.