Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update projects to net7.0 TargetFramework with shared property #1803

Merged
merged 4 commits into from
Aug 30, 2022

Conversation

lbussell
Copy link
Contributor

Fixes #1792

From that issue:

Source build requires projects to build with the current TFM or a supported netstandard TFM. command-line-api currently targets net6.0. Ideally this would be updated to net7.0. If that is not possible, the TFM could be conditioned for source-build but ideally the regular and source build would be identical.

@lbussell
Copy link
Contributor Author

I'm seeing this error when testing locally:

/home/logan/vcs/command-line-api/src/System.CommandLine/Binding/ArgumentConverter.DefaultValues.cs(34,20): error IL2070: 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicParameterlessConstructor' in call to 'System.Type.GetConstructor(Type[])'. The parameter 'listType' of method 'System.CommandLine.Binding.ArgumentConverter.CreateEmptyList(Type)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. [/home/logan/vcs/command-line-api/src/System.CommandLine/System.CommandLine.csproj]

Not sure what to change to fix this.

cc @jonsequitur

@MichaelSimons
Copy link
Member

@jonsequitur - this is ready for a final review.

@jonsequitur jonsequitur merged commit e5861a7 into dotnet:main Aug 30, 2022
@MichaelSimons MichaelSimons deleted the net7.0-tfm branch August 30, 2022 19:15
@lbussell
Copy link
Contributor Author

@jonsequitur, @brettfo, will these changes flow into SDK and eventually installer/release/7.0.1xx? It's been a while since this was merged and usually changes flow by then. If not, then where do I need to backport this change to?

@MichaelSimons
Copy link
Member

Ping @jonsequitur, @brettfo.

@nagilson
Copy link
Member

nagilson commented Oct 7, 2022

Hi, we set up a darc feed for you dotnet/sdk#28410

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update projects to build net7.0 TFM
5 participants