Vstest honor nologo

[mayankbansal018]

Passing /nologo user input to VSTest task

Related: microsoft/vstest#1717

Bug: microsoft/vstest#1701

[mayankbansal018]

@smadala , for review

[mayankbansal018]

@dotnet-bot please test Ubuntu x64 Release

[mayankbansal018]

@dotnet-bot test this please

[mayankbansal018]

@livarcocc , can you please merge this PR

[peterhuene]

This looks good. Can we add a unit test to cover the suppression of VSTest's logo when --nologo is passed to dotnet test?

[mayankbansal018]

@peterhuene , I will add unit tests, once we have inserted our latest sdk, which supports this. Do we want to wait till then to merge the PR?

[peterhuene]

Hi @mayankbansal018,

Sorry, this fell of my radar when I was on vacation. Since 2.1.4xx has shipped and this might not meet the 2.2.100 bar at this point, could you retarget this PR at master (i.e. 3.0)?

Additionally, I'd hold off merging this until you have a test SDK inserted (or can do so as part of this PR) so we can have a test added. It's fine to also add the test now for review purposes and have the PR CI fail, which can then be rerun once the test SDK is inserted.

[peterhuene]

Hi @mayankbansal018. I just wanted to follow up and make sure we retarget this PR against master. We should be able to easily insert a new test SDK there as well. Thanks!

[peterhuene]

Hi @mayankbansal018,

I just wanted to follow-up one more time so that we don't lose track of this PR. Is this still something the test team wants to move forward with for 3.0?

Thanks!

[mayankbansal018]

Thanks @peterhuene , for keeping track of this, unfortunately this slipped from my mind. I'll raise a new PR against appropriate branch.

[livarcocc]

Fixes https://github.com/dotnet/cli/issues/10165.

[livarcocc]

Closing in favor of #10662.