This repository was archived by the owner on Feb 25, 2021. It is now read-only.
Switch to embedded PackageIcon #1896
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Looks like we don't need to worry about the |
Member
Author
|
With the last change, this now includes the icon metadata in all .nuspec's, including the manually generated ones - @dougbu PTAL |
dougbu
approved these changes
Sep 24, 2019
Contributor
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
Looks good but should target 'release/3.0'
Member
Author
|
Closing in favor of #1897 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of aspnet/AspNetCore-Internal#3146
Local build passes the smell test with these changes. I'm still unsure on whether or not we need to include a reference to the package icon in the
.nuspec- the "old way" did so automatically, the "new way" does not (https://docs.microsoft.com/en-us/nuget/reference/msbuild-targets#packing-an-icon-image-file). CC @nkolev92 who may know more about that question.