Skip to content

Conversation

@pranavkm
Copy link
Contributor

@pranavkm pranavkm requested a review from Tratcher as a code owner February 21, 2019 14:28
pranavkm and others added 3 commits February 21, 2019 09:06
#7751)

* Throw if CORS policy is configured to allow credentials and any origin

Fixes #3106
* Fix package type to match spec ('DotnetPlatform')
* Fix missing metadata in MSI installer
* Fix incorrect target order which caused duplicate assemblies in netcore.app and aspnetcore.app
@natemcmaster natemcmaster requested a review from dougbu as a code owner February 21, 2019 17:29
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though I hope the other commits in this PR go away when you rebase

@natemcmaster natemcmaster merged commit fbaa3e8 into master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants