Repository navigation
[release/8.0] Scope sections E2E assertions to mounted app - #69253
Merged
wtgodbe merged 1 commit intoSep 14, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Hi @wtgodbe. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved issues were identified that would block approval.
Pull request overview
Scopes Sections E2E paragraph assertions to the mounted test component, avoiding interference from unrelated BasicTestApp markup.
Changes:
- Stores the mounted app element in both test classes.
- Uses the mounted element for all paragraph lookups.
File summaries
| File | Description |
|---|---|
| src/Components/test/E2ETest/Tests/SectionsWithErrorBoundaryTest.cs | Updated as part of this pull request. |
| src/Components/test/E2ETest/Tests/SectionsWithCascadingParametersTest.cs | Updated as part of this pull request. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
wtgodbe
added
the
tell-mode
This was referenced Oct 13, 2026
Closed
This was referenced Oct 17, 2026
Bump the nuget-api-tests-minor-patch group with 12 updates
Alexandre-Cerveau-Audebeau/SmartCrops#324
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The recent JavaScript root component servicing change added a top-level
<p>toBasicTestApp. The sections E2E tests used a document-wide paragraph selector, so they started reading that unrelated element instead of the content rendered by the mounted test component.Capture the mounted app element and scope paragraph lookups to it. This follows the existing pattern in
SectionsTestand fixes the deterministic failures affecting the release/8.0 Components E2E pipeline and #69209.