Skip to content

Avoid duplicate framework builds from Components E2E publishes #68650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 3 commits into from
Aug 19, 2026
Merged

Avoid duplicate framework builds from Components E2E publishes #68650

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a6199b
Avoid duplicate framework builds from E2E publishes
wtgodbe Aug 19, 2026
5bebd5b
Keep the E2E race workaround repo-local
wtgodbe Aug 19, 2026
8cb30b3
Preserve E2E app publish properties
wtgodbe Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Components/Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.targets))\Directory.Build.targets" />

<!-- E2E app publishes use app-specific global properties while their framework dependencies
share the repository's normal build outputs. Do not create property-distinct dependency
builds that can concurrently rewrite those shared outputs. -->
<ItemDefinitionGroup Condition="'$(IsTestAssetProject)' == 'true'">
<ProjectReference>
<UndefineProperties>%(UndefineProperties);E2ECompileTestHarness;E2EAppMode;PublishDir;_E2EIsPublishing</UndefineProperties>
</ProjectReference>
</ItemDefinitionGroup>

<!-- After ResolveReferences.targets (imported above) converts Reference to ProjectReference
at evaluation time (which drops all custom metadata), re-apply metadata at evaluation
time so it is always in effect for every build phase (Build, Publish, Razor, etc.):
Expand Down
4 changes: 4 additions & 0 deletions src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,10 @@
<_E2EAppProjects Condition="'%(_E2EAppProjects.E2EAppMode)' == ''">
<E2EAppMode>$(E2EAppMode)</E2EAppMode>
</_E2EAppProjects>
<!-- These properties control test-host packaging and must not distinguish the app build. -->
<_E2EAppProjects>
<UndefineProperties>%(_E2EAppProjects.UndefineProperties);_E2EIsPublishing;E2EAppMode</UndefineProperties>
</_E2EAppProjects>
Comment thread
wtgodbe marked this conversation as resolved.
Resolved
<_E2ESourceAppProjects Include="@(_E2EAppProjects)" Condition="'%(_E2EAppProjects.E2EAppMode)' == 'build' or '%(_E2EAppProjects.E2EAppMode)' == 'all'" />
<_E2EPublishPrimaryAppProjects Include="@(_E2EAppProjects)" Condition="'%(_E2EAppProjects.E2EAppMode)' == 'publish'" />
<_E2EPublishSecondaryAppProjects Include="@(_E2EAppProjects)" Condition="'%(_E2EAppProjects.E2EAppMode)' == 'all' and '%(_E2EAppProjects.E2ENativeAot)' != 'true'" />
Expand Down Expand Up @@ -175,7 +179,7 @@
Condition="'@(_E2EAppProjects)' != '' and '$(_E2ETasksAssembly)' == ''" />

<!-- Generate manifest -->
<GenerateE2EManifest

Check failure on line 182 in src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr (Tests: Ubuntu x64)

src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets#L182 

src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets(182,5): error : Could not find the Native AOT executable for compiled E2E app 'NativeAotTestApp' at '/mnt/vss/_work/1/s/artifacts/bin/NativeAotTestApp.E2E.Tests/Release/net11.0/e2e-apps/NativeAotTestApp/NativeAotTestApp'. Compiled harness entries never fall back to 'dotnet NativeAotTestApp.dll'.

Check failure on line 182 in src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets

View check run for this annotation

Azure Pipelines / aspnetcore-ci (Build Test: Ubuntu x64)

src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets#L182 

src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets(182,5): error : Could not find the Native AOT executable for compiled E2E app 'NativeAotTestApp' at '/mnt/vss/_work/1/s/artifacts/bin/NativeAotTestApp.E2E.Tests/Release/net11.0/e2e-apps/NativeAotTestApp/NativeAotTestApp'. Compiled harness entries never fall back to 'dotnet NativeAotTestApp.dll'.

Check failure on line 182 in src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets

View check run for this annotation

Azure Pipelines / aspnetcore-quarantined-pr

src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets#L182 

src/Components/Testing/eng/targets/Microsoft.AspNetCore.Components.Testing.targets(182,5): error : Could not find the Native AOT executable for compiled E2E app 'NativeAotTestApp' at '/mnt/vss/_work/1/s/artifacts/bin/NativeAotTestApp.E2E.Tests/Release/net11.0/e2e-apps/NativeAotTestApp/NativeAotTestApp'. Compiled harness entries never fall back to 'dotnet NativeAotTestApp.dll'.
AppItems="@(_E2EAppProjects)"
ManifestPath="$(_ManifestPath)"
E2EAppsOutputDir="$(_E2EAppsOutputDir)"
Expand Down
Loading