Document framework assembly access rule - #68493
Merged
PureWeen merged 2 commits intoAug 13, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Documents a framework-wide guideline in the repo’s Copilot instructions to avoid new cross-assembly access to non-public members via InternalsVisibleTo or UnsafeAccessor, and to prefer explicit public APIs via the API review/baseline process. This helps keep the guidance from #68365 durable and discoverable for future contributors and coding agents.
Changes:
- Adds a new “Framework assembly boundaries” section to
.github/copilot-instructions.md. - Explicitly states the rule against
InternalsVisibleTo/UnsafeAccessorfor new cross-assembly access. - Directs contributors to design public APIs and follow the API review/baseline process instead.
Show a summary per file
| File | Description |
|---|---|
| .github/copilot-instructions.md | Adds durable guidance on respecting ASP.NET Core framework assembly boundaries and avoiding new cross-assembly non-public access bridges. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
javiercn
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the framework-wide rule against adding
InternalsVisibleToor[UnsafeAccessor]in shipping framework code to reach non-public members in another framework assembly. The assembly boundary should be redesigned instead; if that requires a public API, the repository API-review and baseline process applies.This makes the guidance from #68365 (comment) durable for future contributors and coding agents, while clarifying that existing uses are not precedent for new ones.