Fix ANCM app_offline.htm notification match using QueryCCH - #68341
Merged
Conversation
Contributor
|
Thanks for your PR, @aw0lid. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
aw0lid
force-pushed
the
fix/ancm-filewatcher
branch
3 times, most recently
from
August 11, 2026 12:26
b92814b to
c21892e
Compare
aw0lid
marked this pull request as ready for review
August 11, 2026 14:23
aw0lid
force-pushed
the
fix/ancm-filewatcher
branch
from
August 14, 2026 11:50
c21892e to
83b61c5
Compare
aw0lid
force-pushed
the
fix/ancm-filewatcher
branch
from
August 14, 2026 12:10
83b61c5 to
e452474
Compare
Contributor
Author
|
Hi everyone, could someone please re-run the failed checks? Here are the errors from the build logs: azure-pipelines/ aspnetcore-ci (Build Monitor Helix Jobs)
Build log #L92
One or more non-monitor pipeline jobs failed.
azure-pipelines/ aspnetcore-ci (Build Monitor Helix Jobs)
Build log #L94
Bash exited with code '1'.
azure-pipelines/ aspnetcore-ci (Build Test: Windows Server x64)
CSC#L0
CSC(0,0): error CS2012: Cannot open 'D:\a\_work\1\s\artifacts\obj\Microsoft.Extensions.Localization.Abstractions\Release\net11.0\Microsoft.Extensions.Localization.Abstractions.pdb' for writing -- The requested operation cannot be performed on a file with a user-mapped section open. : 'D:\a\_work\1\s\artifacts\obj\Microsoft.Extensions.Localization.Abstractions\Release\net11.0\Microsoft.Extensions.Localization.Abstractions.pdb'.
azure-pipelines/ aspnetcore-ci (Build Test: Windows Server x64)
CSC#L0
CSC(0,0): error CS2012: Cannot open 'D:\a\_work\1\s\artifacts\obj\Microsoft.JSInterop\Release\net11.0\Microsoft.JSInterop.pdb' for writing -- The requested operation cannot be performed on a file with a user-mapped section open. : 'D:\a\_work\1\s\artifacts\obj\Microsoft.JSInterop\Release\net11.0\Microsoft.JSInterop.pdb'.
azure-pipelines/ aspnetcore-ci (Build Test: Windows Server x64)
CSC#L0
CSC(0,0): error CS2012: Cannot open 'D:\a\_work\1\s\artifacts\obj\Microsoft.AspNetCore.Components\Release\net11.0\Microsoft.AspNetCore.Components.pdb' for writing -- The requested operation cannot be performed on a file with a user-mapped section open. : 'D:\a\_work\1\s\artifacts\obj\Microsoft.AspNetCore.Components\Release\net11.0\Microsoft.AspNetCore.Components.pdb'.Thank you! |
Member
You can re-run them yourself by closing and re-opening the PR, or merging the latest code from main and pushing that. |
Contributor
Author
|
Hi everyone, a quick update: the core build and test checks have passed successfully. The remaining failures are separate from this PR's changes. The PR is ready for code review. Thank you! |
BrennanConroy
approved these changes
Aug 14, 2026
Member
|
/ba-g unrelated |
Member
|
Thanks @aw0lid! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ANCM app_offline.htm notification match using QueryCCH
Description
Fixes an issue in file watcher where
FILE_WATCHER::HandleChangeCompletioncompared the buffer capacity (QuerySizeCCH()) instead of the actual string length (QueryCCH()) against the notified filename length. This made the notification-drivenapp_offline.htmmatch path unreachable, causing the application to rely solely on the fallback existence check.Changes
_strFileName.QuerySizeCCH()with_strFileName.QueryCCH()infilewatcher.cpp.FileWatcherTestsinfilewatcher.h.MockAppOfflineTrackingApplicationinFakeClasses.cpp.filewatcher_tests.cpp.filewatcher_tests.cppinCommonLibTests.vcxproj.Fixes #68283