Repository navigation
Prevent SFX restores from overwriting assets for another RID #68254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
178daf5
Improve stale SFX restore diagnostics
Copilot d02a005
Skip SFX asset validation in design-time builds
Copilot 75a82fe
Merge origin/main into stale assets diagnostics
Copilot 1fd27b2
Improve assets inspection diagnostics
Copilot 79b0486
Scope SFX restore assets by runtime identifier
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System; | ||
| using System.IO; | ||
| using System.Text.Json; | ||
| using Microsoft.Build.Framework; | ||
|
|
||
| namespace RepoTasks; | ||
|
|
||
| /// <summary> | ||
| /// Checks whether a NuGet assets file contains a target for a target framework | ||
| /// and runtime identifier. | ||
| /// </summary> | ||
| public sealed class CheckProjectAssetsRuntimeTarget : Microsoft.Build.Utilities.Task | ||
| { | ||
| /// <summary> | ||
| /// Gets or sets the NuGet project assets file to inspect. | ||
| /// </summary> | ||
| [Required] | ||
| public string ProjectAssetsFile { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the target framework to find. | ||
| /// </summary> | ||
| [Required] | ||
| public string TargetFramework { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets or sets the runtime identifier to find. | ||
| /// </summary> | ||
| [Required] | ||
| public string RuntimeIdentifier { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// Gets whether the requested runtime target exists. | ||
| /// </summary> | ||
| [Output] | ||
| public bool RuntimeTargetExists { get; private set; } | ||
|
|
||
| /// <inheritdoc /> | ||
| public override bool Execute() | ||
| { | ||
| try | ||
| { | ||
| using var stream = File.OpenRead(ProjectAssetsFile); | ||
| using var document = JsonDocument.Parse(stream); | ||
| var targetName = $"{TargetFramework}/{RuntimeIdentifier}"; | ||
|
|
||
| RuntimeTargetExists = | ||
| document.RootElement.TryGetProperty("targets", out var targets) && | ||
| targets.TryGetProperty(targetName, out _); | ||
|
|
||
| return true; | ||
| } | ||
| catch (Exception exception) when (exception is IOException or UnauthorizedAccessException or JsonException or InvalidOperationException) | ||
| { | ||
| Log.LogError($"Unable to inspect NuGet assets file '{ProjectAssetsFile}': {exception.Message}"); | ||
|
PureWeen marked this conversation as resolved.
Resolved
|
||
| return false; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.