Skip to content

Fix double-publish compression error in TestContentPackage #68085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilonatommy merged 1 commit into from
Aug 3, 2026
Merged

Fix double-publish compression error in TestContentPackage #68085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Components/test/testassets/TestContentPackage/TestContentPackage.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@
<StaticWebAssetBasePath>_content/TestContentPackage</StaticWebAssetBasePath>
</PropertyGroup>

<PropertyGroup Condition="'$(_SkipReferencedProjectPublishAssets)' == 'true'">

@wtgodbe wtgodbe Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure _SkipReferencedProjectPublishAssets will be set here when we need it to?

@wtgodbe wtgodbe Jul 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the issue is that  Components.TestServer.csproj references BasicTestApp.csproj and Components.WasmMinimal.csproj, both of which reference this project w/ identical global properties, so there's a race

@ilonatommy ilonatommy Jul 30, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the race is the reason for double publish. As you say, we have something like

Components.TestServer
|___BasicTestApp
|     |___TestContentPackage
|___ Components.WasmMinimal
      |___TestContentPackage

and when E2ETests.csproj is built we have both: BasicTestApp.csproj

aspnetcore/src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj

Line 101 in 2e05e26

<ProjectReference Include="..\testassets\BasicTestApp\BasicTestApp.csproj" Targets="Build;Publish" Properties="BuildProjectReferences=false;TestTrimmedApps=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\BasicTestApp\" />

and Components.TestServer

aspnetcore/src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj

Line 109 in 2e05e26

<ProjectReference Include="..\testassets\Components.TestServer\Components.TestServer.csproj" Targets="Build;Publish" Properties="BuildProjectReferences=false;TestTrimmedApps=true;_SkipReferencedProjectPublishAssets=true;PublishDir=$(MSBuildThisFileDirectory)$(OutputPath)trimmed\Components.TestServer\;" />

publish triggered. The first one is missing _SkipReferencedProjectPublishAssets property, the latter has it set. That's good. That means that one of the publishes will be skipped, the other one won't. That eliminate the race. Do I get it right?

@wtgodbe wtgodbe Jul 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that seems like it should work

<StaticWebAssetsGetPublishAssetsTargets>_SkipGetPublishAssetsForTrimmedBuild</StaticWebAssetsGetPublishAssetsTargets>
</PropertyGroup>

<!-- No-op target used to prevent the Static Web Assets SDK from redundantly re-publishing this project. -->
<Target Name="_SkipGetPublishAssetsForTrimmedBuild" />

<ItemGroup>
<Reference Include="Microsoft.AspNetCore.Components" />
<Reference Include="Microsoft.AspNetCore.Components.Authorization" />
Expand Down
Loading