Skip to content

[release/8.0] Drop Microsoft.AspNetCore.Grpc.Swagger - #67955

Merged
wtgodbe merged 2 commits into
release/8.0from
copilot/backport-67919-to-release-8-0
Aug 11, 2026
Merged

[release/8.0] Drop Microsoft.AspNetCore.Grpc.Swagger#67955
wtgodbe merged 2 commits into
release/8.0from
copilot/backport-67919-to-release-8-0

Conversation

Copilot AI commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Drop Microsoft.AspNetCore.Grpc.Swagger

This is a backport of #67919 which removes the experimental Microsoft.AspNetCore.Grpc.Swagger.

Description

See #67134

This package has been experimental with relatively low usage.

https://www.nuget.org/packages/Microsoft.AspNetCore.Grpc.Swagger -> Current version (released 23 days ago) 36K downloads.

In contrast, https://www.nuget.org/packages/Swashbuckle.AspNetCore.Swagger has 7.6M downloads for current version (released only a month ago), and https://www.nuget.org/packages/Microsoft.AspNetCore.OpenApi has 2M downloads for current version (released 23 days ago).

The package adds maintenance cost that's not worth it.

Customer Impact

No new experimental versions of this package will be published.

Regression?

N/A

Risk

Low - intentional package deprecation.

Verification

N/A

Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
Copilot AI requested a review from Youssef1313 July 22, 2026 07:20
@Youssef1313
Youssef1313 marked this pull request as ready for review July 22, 2026 07:23
@Youssef1313
Youssef1313 requested a review from JamesNK as a code owner July 22, 2026 07:23
Copilot AI review requested due to automatic review settings July 22, 2026 07:23
@Youssef1313
Youssef1313 requested review from a team and wtgodbe as code owners July 22, 2026 07:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the Microsoft.AspNetCore.Grpc.Swagger package (and its associated tests/assets) from release/8.0, along with build/solution plumbing and Sandbox usage, to reduce shipped surface area and eliminate stale dependencies.

Changes:

  • Deletes the Microsoft.AspNetCore.Grpc.Swagger source project and its PublicAPI baselines.
  • Deletes the Microsoft.AspNetCore.Grpc.Swagger.Tests project plus supporting test services/protos.
  • Removes remaining wiring/references from build metadata (eng props), src/Grpc/Grpc.slnf, and the JsonTranscoding Sandbox testasset.

Reviewed changes

Copilot reviewed 39 out of 39 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Grpc/JsonTranscoding/test/testassets/Sandbox/Startup.cs Removes Swagger/OpenAPI middleware and service registration from the Sandbox test asset.
src/Grpc/JsonTranscoding/test/testassets/Sandbox/Sandbox.csproj Drops the Microsoft.AspNetCore.Grpc.Swagger reference from the Sandbox test asset.
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/XmlComments/XmlDocumentationIntegrationTests.cs Deletes Grpc.Swagger XML-docs integration tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/XmlComments/XmlCommentsDocumentFilterTests.cs Deletes Grpc.Swagger XML-docs document-filter tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/XmlDocServiceWithComments.cs Deletes test service used by Grpc.Swagger XML comment coverage.
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/XmlDocService.cs Deletes test service used by Grpc.Swagger XML/proto-doc coverage.
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/ParametersService.cs Deletes test service used by parameter binding tests for Grpc.Swagger.
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/GreeterService.cs Deletes test service used by basic OpenAPI generation tests for Grpc.Swagger.
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Services/BodyService.cs Deletes test service used by body binding tests for Grpc.Swagger.
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/SchemaGeneratorIntegrationTests.cs Deletes schema generation integration tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/xmldoc.proto Deletes proto used by XML documentation tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/parameters.proto Deletes proto used by parameter binding tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/messages.proto Deletes proto used by schema generation tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/greeter.proto Deletes proto used by basic operation generation tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/counter.proto Deletes proto used by grouped swagger doc tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Proto/body.proto Deletes proto used by body binding tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Microsoft.AspNetCore.Grpc.Swagger.Tests.csproj Deletes the Grpc.Swagger test project definition.
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Infrastructure/TestWebHostEnvironment.cs Deletes test infrastructure type (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Infrastructure/OpenApiTestHelpers.cs Deletes OpenAPI test helper infrastructure (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/GrpcSwaggerServiceExtensionsTests.cs Deletes extension-method behavior tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/google/api/http.proto Deletes vendored google.api.http proto used by tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/google/api/annotations.proto Deletes vendored google.api.annotations proto used by tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Binding/ParametersTests.cs Deletes parameter binding tests (project removal).
src/Grpc/JsonTranscoding/test/Microsoft.AspNetCore.Grpc.Swagger.Tests/Binding/BodyTests.cs Deletes body binding tests (project removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/PublicAPI.Unshipped.txt Deletes PublicAPI baseline file (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/PublicAPI.Shipped.txt Deletes shipped API baseline file (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Microsoft.AspNetCore.Grpc.Swagger.csproj Deletes the Grpc.Swagger package project.
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/XmlComments/GrpcXmlCommentsOperationFilter.cs Deletes internal XML comment operation filter implementation (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/XmlComments/GrpcXmlCommentsDocumentFilter.cs Deletes internal XML comment document filter implementation (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/MessageDescriptorHelpers.cs Deletes internal protobuf descriptor helper code (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcModelMetadata.cs Deletes internal ModelMetadata implementation (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcJsonTranscodingDescriptionProvider.cs Deletes internal ApiExplorer description provider used for OpenAPI generation (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/Internal/GrpcDataContractResolver.cs Deletes internal Swashbuckle data contract resolver (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/GrpcSwaggerServiceExtensions.cs Deletes public DI extensions (AddGrpcSwagger) (package removal).
src/Grpc/JsonTranscoding/src/Microsoft.AspNetCore.Grpc.Swagger/GrpcSwaggerGenOptionsExtensions.cs Deletes public SwaggerGen extensions (IncludeGrpcXmlComments) (package removal).
src/Grpc/Grpc.slnf Removes Grpc.Swagger projects from the gRPC solution filter.
eng/ShippingAssemblies.props Stops shipping Microsoft.AspNetCore.Grpc.Swagger as part of the shared framework assembly list.
eng/RequiresDelayedBuildProjects.props Removes Grpc.Swagger projects from the delayed-build project list.
eng/ProjectReferences.props Removes Grpc.Swagger from centralized project reference providers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Grpc/Grpc.slnf
Co-authored-by: Youssef1313 <31348972+Youssef1313@users.noreply.github.com>
@Youssef1313

Copy link
Copy Markdown
Member

/ba-g Build check is expected to fail here. Quarantined timeout isn't related and not important.

@Youssef1313 Youssef1313 added the Servicing-consider Shiproom approval is required for the issue label Aug 6, 2026
@wtgodbe wtgodbe added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Aug 11, 2026
@wtgodbe
wtgodbe merged commit 2aac9eb into release/8.0 Aug 11, 2026
21 of 25 checks passed
@wtgodbe
wtgodbe deleted the copilot/backport-67919-to-release-8-0 branch August 11, 2026 17:36
This was referenced Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants