Use build identity (System.AccessToken) for internal feed creds instead of expired dn-bot-dnceng-artifact-feeds-rw PAT (release/8.0) - #67854
Merged
wtgodbe merged 2 commits intoJul 16, 2026
Conversation
…expired dn-bot-dnceng-artifact-feeds-rw PAT Replaces the SetupNugetSources PAT-credential steps with NuGetAuthenticate@1. The PAT expired 2026-07-11 (removed from arcade secret manifest, PR #17079), causing 401s on darc-int-* and dotnet-*-internal feeds. The build service identity has read access to these feeds; feed sources are already in NuGet.config. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 331a413c-8b88-448e-8913-6ca49130a046
…ad of expired dn-bot-dnceng-artifact-feeds-rw PAT Keeps SetupNugetSources (which re-enables the disabled darc-int sources) and feeds it the pipeline build-service OAuth token instead of the decommissioned PAT. The PAT expired 2026-07-11 (removed from arcade manifest, PR #17079). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 331a413c-8b88-448e-8913-6ca49130a046
missymessa
changed the title
missymessa
marked this pull request as ready for review
July 16, 2026 19:47
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the internal build pipeline to authenticate to Azure DevOps internal NuGet feeds using the build’s OAuth identity token ($(System.AccessToken)) instead of the expired dn-bot-dnceng-artifact-feeds-rw PAT, while keeping the SetupNugetSources step that re-enables disabled darc-int-* sources in NuGet.config.
Changes:
- Switch
Setup Private Feeds Credentials(PowerShell/Bash) to pass$(System.AccessToken)intoSetupNugetSourcesfor feed credentials. - Preserve the
SetupNugetSourcesinvocation sodarc-int-*sources remain enabled for restores.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
416
to
+420
| inputs: | ||
| filePath: $(Build.SourcesDirectory)/eng/common/SetupNugetSources.ps1 | ||
| arguments: -ConfigFile $(Build.SourcesDirectory)/NuGet.config -Password $Env:Token | ||
| env: | ||
| Token: $(dn-bot-dnceng-artifact-feeds-rw) | ||
| Token: $(System.AccessToken) |
akoeplinger
approved these changes
Jul 16, 2026
wtgodbe
approved these changes
Jul 16, 2026
Member
|
Merging to unblock internal builds |
wtgodbe
added
the
tell-mode
This was referenced Jul 16, 2026
missymessa
added a commit
that referenced
this pull request
Jul 16, 2026
Removing the credential entirely (relying only on NuGetAuthenticate) is insufficient because the Arcade toolset bootstrap restore reads credentials directly from NuGet.config. Pass the build identity OAuth token via legacyCredential so SetupNugetSources writes it to NuGet.config. Matches release/8.0 (#67854). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 331a413c-8b88-448e-8913-6ca49130a046
wtgodbe
pushed a commit
that referenced
this pull request
Jul 16, 2026
* Use System.AccessToken for internal feed auth on release/9.0 Removing the credential entirely (relying only on NuGetAuthenticate) is insufficient because the Arcade toolset bootstrap restore reads credentials directly from NuGet.config. Pass the build identity OAuth token via legacyCredential so SetupNugetSources writes it to NuGet.config. Matches release/8.0 (#67854). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 331a413c-8b88-448e-8913-6ca49130a046 * Only pass legacyCredential when System.TeamProject == internal Avoids forcing the enable-internal-sources template down the legacy PAT path for non-internal (e.g. DevDiv) projects, preserving the federated service-connection auth flow there. Addresses Copilot review feedback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 331a413c-8b88-448e-8913-6ca49130a046 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Aug 11, 2026
Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.28 to 8.0.30
TechnologyEnhancedLearning/TELBlazor#477
Open
Open
Open
Bump Microsoft.AspNetCore.Identity.EntityFrameworkCore from 8.0.29 to 8.0.30
ardqe0/RestaurantApp#51
Open
This was referenced Aug 13, 2026
Closed
Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.27 to 8.0.30
NanoRes-Admin/multiview-cpf-assurance#10
Open
Open
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internal official builds fail restore with HTTP 401 on
darc-int-*/dotnet-*-internalfeeds becausedn-bot-dnceng-artifact-feeds-rwwas removed from the arcade secret manifest (arcade #17079) and expired 2026-07-11.Change
The 8.0
SetupNugetSources.ps1has a mandatory-Password, and it is also the step that re-enables thedarc-intsources (which ship disabled inNuGet.configvia<disabledPackageSources>). So dropping it and relying onNuGetAuthenticate@1alone would not work — the sources would stay disabled. Instead this keeps theSetup Private Feeds Credentialstask and swaps the credential from the dead PAT to the pipeline's build-service OAuth token$(System.AccessToken).$(System.AccessToken)is the dnceng/internal Project Build Service identity, which has read access to all affected feeds — this is the intended "build identity instead of PAT" migration for feeds hosted in the same AzDO org.Validation
SetupNugetSourcesstill enables the disableddarc-intsources.darc-int-*/dotnet-*-internal.Tracking: dnceng/internal AB#11679.