Skip to content

Fix InputBase parse failure triggering unnecessary field validation #65574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kubaflo wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −4
Open

Fix InputBase parse failure triggering unnecessary field validation #65574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Components/Web/src/Forms/InputBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@ protected string? CurrentValueAsString
{
_parsingValidationMessages ??= new ValidationMessageStore(EditContext);
_parsingValidationMessages.Add(FieldIdentifier, validationErrorMessage);

// Since we're not writing to CurrentValue, we'll need to notify about modification from here
EditContext.NotifyFieldChanged(FieldIdentifier);
}
}

Expand Down
23 changes: 22 additions & 1 deletion src/Components/Web/test/Forms/InputBaseTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ public async Task ParsesCurrentValueAsStringWhenChanged_Invalid()
// Act/Assert 1: Transition to invalid
await inputComponent.SetCurrentValueAsStringAsync("1991/11/40");
Assert.Empty(valueChangedArgs);
Assert.True(rootComponent.EditContext.IsModified(fieldIdentifier));
Assert.False(rootComponent.EditContext.IsModified(fieldIdentifier));
Assert.Equal(new[] { "Bad date value" }, rootComponent.EditContext.GetValidationMessages(fieldIdentifier));
Assert.Equal(1, numValidationStateChanges);

Expand All @@ -337,6 +337,27 @@ public async Task ParsesCurrentValueAsStringWhenChanged_Invalid()
Assert.Equal(2, numValidationStateChanges);
}

[Fact]
public async Task ParsesCurrentValueAsStringWhenChanged_Invalid_DoesNotNotifyFieldChanged()
{
var model = new TestModel();
var rootComponent = new TestInputHostComponent<DateTime, TestDateInputComponent>
{
EditContext = new EditContext(model),
ValueExpression = () => model.DateProperty
};
var fieldIdentifier = FieldIdentifier.Create(() => model.DateProperty);
var inputComponent = await InputRenderer.RenderAndGetComponent(rootComponent);
var numFieldChanges = 0;
rootComponent.EditContext.OnFieldChanged += (sender, eventArgs) => { numFieldChanges++; };

await inputComponent.SetCurrentValueAsStringAsync("1991/11/40");

Assert.False(rootComponent.EditContext.IsModified(fieldIdentifier));
Assert.Equal(0, numFieldChanges);
Assert.Equal(new[] { "Bad date value" }, rootComponent.EditContext.GetValidationMessages(fieldIdentifier));
}

[Fact]
public async Task ClearsParsingValidationMessagesWhenDisposed()
{
Expand Down
Loading