Skip to content

[release/10.0] Disable parallel restore for linker tests #65373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 6 commits into from
Feb 10, 2026
Merged

[release/10.0] Disable parallel restore for linker tests #65373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
816c20d
Disable parallel restore for linker tests
wtgodbe Feb 9, 2026
a124e25
Disable parallel restore for trimming tests
wtgodbe Feb 9, 2026
f0a5010
Update comment to reference new GitHub issue
wtgodbe Feb 9, 2026
f703b81
Add property to disable parallel restore for trimming tests
wtgodbe Feb 9, 2026
71e709a
Update PublishTrimmedProjects target to disable parallel restore
wtgodbe Feb 9, 2026
c14d655
Fix closing tag for PropertyGroup in Directory.Build.props
wtgodbe Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,11 @@
<DisableLogTaskParameterItemMetadata_Csc_References>$(TrimTaskParameters)</DisableLogTaskParameterItemMetadata_Csc_References>
</PropertyGroup>

<PropertyGroup Condition="'$(IsTrimmingTestProject)' == 'true'">
<!-- Should mitigate https://github.com/dotnet/aspnetcore/issues/61178 -->
<RestoreDisableParallel>true</RestoreDisableParallel>
</PropertyGroup>

<Import Project="eng\QuarantinedTests.BeforeArcade.props" />
<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
<Import Project="eng\QuarantinedTests.AfterArcade.props" />
Expand Down
2 changes: 2 additions & 0 deletions eng/testing/linker/project.csproj.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
<InterceptorsPreviewNamespaces>$(InterceptorsPreviewNamespaces);Microsoft.AspNetCore.Http.Generated;Microsoft.Extensions.Validation.Generated</InterceptorsPreviewNamespaces>
<!-- Ensure individual warnings are shown when publishing -->
<TrimmerSingleWarn>false</TrimmerSingleWarn>
<!-- Should mitigate https://github.com/dotnet/aspnetcore/issues/61178 -->
<RestoreDisableParallel>true</RestoreDisableParallel>
{AdditionalProperties}
</PropertyGroup>

Expand Down
3 changes: 2 additions & 1 deletion eng/testing/linker/trimmingTests.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,10 @@
DependsOnTargets="GenerateProjects">

<MSBuild Projects="@(TestConsoleApps)"
BuildInParallel="false"
Targets="Restore"
Condition="'$(SkipTrimmingProjectsRestore)' != 'true'"
Properties="MSBuildRestoreSessionId=$([System.Guid]::NewGuid());Configuration=$(Configuration)" />
Properties="MSBuildRestoreSessionId=$([System.Guid]::NewGuid());Configuration=$(Configuration);RestoreDisableParallel=true" />

<MSBuild Projects="@(TestConsoleApps)"
Targets="Publish"
Expand Down
Loading