Disable parallel restore for linker tests#65372
Merged
Conversation
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies an existing workaround to the linker/trimming test project template to mitigate intermittent restore-time file contention failures (tracked in aspnetcore#61178).
Changes:
- Disable NuGet parallel restore for generated linker test projects by setting
RestoreDisableParallel=true. - Add an inline comment documenting the rationale for disabling parallel restore.
BrennanConroy
approved these changes
Feb 9, 2026
Member
Author
|
/backport to release/10.0 |
Member
Author
|
/backport to release/9.0 |
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to |
Contributor
|
Started backporting to |
Contributor
|
Started backporting to |
11 tasks
Contributor
|
@wtgodbe backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Disable parallel restore for linker tests
Using index info to reconstruct a base tree...
M eng/testing/linker/project.csproj.template
Falling back to patching base and 3-way merge...
Auto-merging eng/testing/linker/project.csproj.template
CONFLICT (content): Merge conflict in eng/testing/linker/project.csproj.template
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Disable parallel restore for linker tests
Error: The process '/usr/bin/git' failed with exit code 128 |
11 tasks
Added a property group to disable parallel restore for trimming test projects to mitigate a specific issue.
This was referenced Feb 9, 2026
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
3 tasks
Member
Author
|
Test failures are dotnet/dnceng#4756 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All remaining instances of #61178 are in the linker tests. This workaround has fixed all the other instances of it, so we should add it here too.