Skip to content

Ensure repeated hyphens are replaced with single hyphens in new projects' localhost host name prefixes #65027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DamianEdwards merged 1 commit into from
Jan 13, 2026
Merged

Ensure repeated hyphens are replaced with single hyphens in new projects' localhost host name prefixes #65027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...ectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/.template.config/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
"steps": [
"lowerCaseInvariant",
"replaceDnsInvalidChars",
"replaceRepeatedHyphens",
"trimLeadingHyphens",
"trimTrailingHyphens"
]
Expand All @@ -217,6 +218,11 @@
"pattern": "[^a-z0-9-]",
"replacement": "-"
},
"replaceRepeatedHyphens": {
"identifier": "replace",
"pattern": "-{2,}",
"replacement": "-"
},
"trimLeadingHyphens": {
"identifier": "replace",
"pattern": "^-+",
Expand Down
6 changes: 6 additions & 0 deletions ...jectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/.template.config/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"steps": [
"lowerCaseInvariant",
"replaceDnsInvalidChars",
"replaceRepeatedHyphens",
"trimLeadingHyphens",
"trimTrailingHyphens"
]
Expand All @@ -63,6 +64,11 @@
"pattern": "[^a-z0-9-]",
"replacement": "-"
},
"replaceRepeatedHyphens": {
"identifier": "replace",
"pattern": "-{2,}",
"replacement": "-"
},
"trimLeadingHyphens": {
"identifier": "replace",
"pattern": "^-+",
Expand Down
3 changes: 2 additions & 1 deletion src/ProjectTemplates/test/Templates.Blazor.Tests/BlazorWebTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@ private async Task TestProjectCoreAsync(Project project, BrowserKind browserKind
[InlineData("my.namespace.blazor", "my-namespace-blazor")]
[InlineData(".StartWithDot", "startwithdot")]
[InlineData("EndWithDot.", "endwithdot")]
[InlineData("My..Test__Project", "my--test--project")]
[InlineData("My..Test__Project", "my-test-project")]
[InlineData("Project123.Test456", "project123-test456")]
[InlineData("xn--My.Test.Project", "xn-my-test-project")]
[SkipOnHelix("Cert failure, https://github.com/dotnet/aspnetcore/issues/28090", Queues = "All.OSX;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
public async Task BlazorWebTemplateLocalhostTld_GeneratesDnsCompliantHostnames(string projectName, string expectedHostname)
{
Expand Down
3 changes: 2 additions & 1 deletion src/ProjectTemplates/test/Templates.Tests/EmptyWebTemplateTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,9 @@ public async Task EmptyWebTemplateNoHttpsFSharp()
[InlineData("my.namespace.web", "my-namespace-web")]
[InlineData(".StartWithDot", "startwithdot")]
[InlineData("EndWithDot.", "endwithdot")]
[InlineData("My..Test__Project", "my--test--project")]
[InlineData("My..Test__Project", "my-test-project")]
[InlineData("Project123.Test456", "project123-test456")]
[InlineData("xn--My.Test.Project", "xn-my-test-project")]
[SkipOnHelix("Cert failure, https://github.com/dotnet/aspnetcore/issues/28090", Queues = "All.OSX;" + HelixConstants.Windows10Arm64 + HelixConstants.DebianArm64)]
public async Task EmptyWebTemplateLocalhostTld_GeneratesDnsCompliantHostnames(string projectName, string expectedHostname)
{
Expand Down
Loading