Skip to content

Fix DNS-invalid hostnames with underscores in dotnet new templates #64988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DamianEdwards merged 10 commits into from
Jan 10, 2026
Merged

Fix DNS-invalid hostnames with underscores in dotnet new templates #64988

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ee22359
Initial plan
Copilot Jan 9, 2026
5b1e1e3
Add DNS-safe hostname forms and symbols to templates
Copilot Jan 9, 2026
f48b724
Add trimming of leading/trailing hyphens for DNS-safe hostnames
Copilot Jan 9, 2026
80a5e82
Use distinct placeholder LocalhostTldHostNamePrefix for hostname repl…
Copilot Jan 9, 2026
4cc41eb
Add tests for DNS-compliant hostname generation with --localhost-tld
Copilot Jan 9, 2026
cac285e
Add tests for DNS-compliant hostname generation in Blazor templates
Copilot Jan 9, 2026
4461e9d
Move VerifyDnsCompliantHostname to shared Project class
Copilot Jan 9, 2026
ec21b91
Fix -n parameter conflict and add tests with numbers in project names
Copilot Jan 9, 2026
d2c69f8
Refactor DNS hostname tests to use Theory with InlineData
Copilot Jan 9, 2026
71c2e9c
Fix razorcomponent item test
DamianEdwards Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ...ectTemplates/Web.ProjectTemplates/content/BlazorWeb-CSharp/.template.config/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,39 @@
]
}
],
"forms": {
"lowerCaseInvariantWithHyphens": {
"identifier": "chain",
"steps": [
"lowerCaseInvariant",
"replaceDnsInvalidChars",
"trimLeadingHyphens",
"trimTrailingHyphens"
]
},
"replaceDnsInvalidChars": {
"identifier": "replace",
"pattern": "[^a-z0-9-]",
"replacement": "-"
},
"trimLeadingHyphens": {
"identifier": "replace",
"pattern": "^-+",
"replacement": ""
},
"trimTrailingHyphens": {
"identifier": "replace",
"pattern": "-+$",
"replacement": ""
}
},
"symbols": {
"hostName": {
"type": "derived",
"valueSource": "name",
"valueTransform": "lowerCaseInvariantWithHyphens",
"replaces": "LocalhostTldHostNamePrefix"
},
Comment thread
DamianEdwards marked this conversation as resolved.
"Framework": {
"type": "parameter",
"description": "The target framework for the project.",
Expand Down
4 changes: 2 additions & 2 deletions ...rojectTemplates/content/BlazorWeb-CSharp/BlazorWebCSharp.1/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"inspectUri": "{wsProtocol}://{url.hostname}:{url.port}/_framework/debug/ws-proxy?browser={browserInspectUri}",
//#endif
//#if (LocalhostTld)
"applicationUrl": "http://blazorwebcsharp__1.dev.localhost:5500",
"applicationUrl": "http://LocalhostTldHostNamePrefix.dev.localhost:5500",
//#else
"applicationUrl": "http://localhost:5500",
//#endif
Expand All @@ -32,7 +32,7 @@
"inspectUri": "{wsProtocol}://{url.hostname}:{url.port}/_framework/debug/ws-proxy?browser={browserInspectUri}",
//#endif
//#if (LocalhostTld)
"applicationUrl": "https://blazorwebcsharp__1.dev.localhost:5501;http://blazorwebcsharp__1.dev.localhost:5500",
"applicationUrl": "https://LocalhostTldHostNamePrefix.dev.localhost:5501;http://LocalhostTldHostNamePrefix.dev.localhost:5500",
//#else
"applicationUrl": "https://localhost:5501;http://localhost:5500",
//#endif
Expand Down
32 changes: 32 additions & 0 deletions ...jectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/.template.config/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,39 @@
]
}
],
"forms": {
"lowerCaseInvariantWithHyphens": {
"identifier": "chain",
"steps": [
"lowerCaseInvariant",
"replaceDnsInvalidChars",
"trimLeadingHyphens",
"trimTrailingHyphens"
]
},
"replaceDnsInvalidChars": {
"identifier": "replace",
"pattern": "[^a-z0-9-]",
"replacement": "-"
},
"trimLeadingHyphens": {
"identifier": "replace",
"pattern": "^-+",
"replacement": ""
},
"trimTrailingHyphens": {
"identifier": "replace",
"pattern": "-+$",
"replacement": ""
}
},
"symbols": {
"hostName": {
"type": "derived",
"valueSource": "name",
"valueTransform": "lowerCaseInvariantWithHyphens",
"replaces": "LocalhostTldHostNamePrefix"
},
Comment thread
DamianEdwards marked this conversation as resolved.
"ExcludeLaunchSettings": {
"type": "parameter",
"datatype": "bool",
Expand Down
4 changes: 2 additions & 2 deletions ...jectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"dotnetRunMessages": true,
"launchBrowser": true,
//#if (LocalhostTld)
"applicationUrl": "http://company_webapplication1.dev.localhost:5000",
Comment thread
DamianEdwards marked this conversation as resolved.
"applicationUrl": "http://LocalhostTldHostNamePrefix.dev.localhost:5000",
//#else
"applicationUrl": "http://localhost:5000",
//#endif
Expand All @@ -24,7 +24,7 @@
"dotnetRunMessages": true,
"launchBrowser": true,
//#if (LocalhostTld)
"applicationUrl": "https://company_webapplication1.dev.localhost:5001;http://company_webapplication1.dev.localhost:5000",
"applicationUrl": "https://LocalhostTldHostNamePrefix.dev.localhost:5001;http://LocalhostTldHostNamePrefix.dev.localhost:5000",
//#else
"applicationUrl": "https://localhost:5001;http://localhost:5000",
//#endif
Expand Down
Loading