Fix command injection vulnerability in WSL certificate trust#64969
Merged
danegsta merged 4 commits intodanegsta/wslCertTrustfrom Jan 7, 2026
Merged
Fix command injection vulnerability in WSL certificate trust#64969danegsta merged 4 commits intodanegsta/wslCertTrustfrom
danegsta merged 4 commits intodanegsta/wslCertTrustfrom
Conversation
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
…ecial characters Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
…S script Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update dev cert support for Windows certificate store in WSL
Fix command injection vulnerability in WSL certificate trust
Jan 7, 2026
This was referenced Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix command injection vulnerability in WSL certificate trust
Fix command injection vulnerability in PowerShell command construction for WSL certificate trust
Description
The
TryTrustCertificateInWindowsStoremethod was vulnerable to command injection through paths containing double quotes, which could break out of the-Command "..."shell string. SincecertificatePathcan be influenced by theDOTNET_DEV_CERTS_OPENSSL_CERTIFICATE_DIRECTORYenvironment variable, malicious values could execute arbitrary commands.Changes
-EncodedCommandwith Base64 encoding: Encode the PowerShell script as UTF-16LE Base64 before passing topowershell.exe, eliminating command shell escaping issuesThis provides two-layer protection: Base64 encoding prevents shell-level injection, single-quote escaping prevents PowerShell-level injection.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.