-
Notifications
You must be signed in to change notification settings - Fork 10.8k
API proposal for NavigateTo and NavLink with relative path
#64670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b731a3c
API proposal for `NavigateTo`.
ilonatommy 2637d93
Move test coverage.
ilonatommy b4ab599
Proposal of NavLink API.
ilonatommy 3d28840
Merge branch 'main' into fix-23615
ilonatommy 443e30a
Make sure relative path is passed when `PathRelative=true`.
ilonatommy f58432f
Feedback: refactor unit tests.
ilonatommy e80969f
Fix test.
ilonatommy 17e2992
Merge branch 'main' into fix-23615
ilonatommy 78ad70b
Fix absolute paths in NavLink.
ilonatommy 88dde4c
Unify: regardless of PathRelative value, ulrs are resolved as relativ…
ilonatommy 6e17d4b
Merge branch 'fix-23615' of https://github.com/ilonatommy/aspnetcore …
ilonatommy 64a0ce9
Feedback: absolute paths and `TryCreate` is safer.
ilonatommy 5a7ab70
Coply with RFC 3986.
ilonatommy 8f1be8e
Rename `PathRelative` -> `RelativeToCurrentUri`.
ilonatommy a164362
Missed renames.
ilonatommy 1bb638c
Feedback: Remove reflection.
ilonatommy 20f9cef
Feedback: consolidate the tests.
ilonatommy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,3 @@ | ||
| #nullable enable | ||
| Microsoft.AspNetCore.Components.NavigationOptions.PathRelative.get -> bool | ||
| Microsoft.AspNetCore.Components.NavigationOptions.PathRelative.init -> void |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.