Skip to content

Fix data-permanent to preserve element attributes, not just descendants#64622

Merged
javiercn merged 3 commits into
mainfrom
copilot/fix-data-permanent-attribute
Jan 21, 2026
Merged

Fix data-permanent to preserve element attributes, not just descendants#64622
javiercn merged 3 commits into
mainfrom
copilot/fix-data-permanent-attribute

Add E2E test for data-permanent attribute preservation

68284e4
Select commit
Loading
Failed to load commit list.
Azure Pipelines / aspnetcore-quarantined-pr succeeded Dec 3, 2025 in 47m 38s

Build #20251203.16 had test failures

Details

Tests

  • Failed: 7 (0.51%)
  • Passed: 1,324 (97.00%)
  • Other: 34 (2.49%)
  • Total: 1,365

Annotations

Check failure on line 262 in .dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

.dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets#L262

.dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(262,5): error NETSDK1085: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'NoBuild' property was set to true but the 'Build' target was invoked.

Check failure on line 262 in .dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

.dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets#L262

.dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(262,5): error NETSDK1085: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'NoBuild' property was set to true but the 'Build' target was invoked.

Check failure on line 262 in .dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

.dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets#L262

.dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(262,5): error NETSDK1085: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'NoBuild' property was set to true but the 'Build' target was invoked.

Check failure on line 262 in .dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

.dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets#L262

.dotnet/sdk/10.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(262,5): error NETSDK1085: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'NoBuild' property was set to true but the 'Build' target was invoked.

Check failure on line 1 in Interop.FunctionalTests.Http3.Http3TlsTests.ClientCertificate_AllowOrRequire_Available_Invalid_Refused

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

Interop.FunctionalTests.Http3.Http3TlsTests.ClientCertificate_AllowOrRequire_Available_Invalid_Refused

Test failed

Check failure on line 1 in Microsoft.AspNetCore.Server.Kestrel.Sockets.FunctionalTests.ResponseTests.HttpsConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

Microsoft.AspNetCore.Server.Kestrel.Sockets.FunctionalTests.ResponseTests.HttpsConnectionClosedWhenResponseDoesNotSatisfyMinimumDataRate

Test failed

Check failure on line 1 in Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.ChangingUserNameDuringReconnectLogsWarning

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.ChangingUserNameDuringReconnectLogsWarning

1 error(s) logged.
Microsoft.AspNetCore.Http.Connections.Client.Internal.WebSocketsTransport - ErrorSendingMessage - Error while sending a message.
===================
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.WebSockets.ClientWebSocket'.
   at System.Net.WebSockets.ClientWebSocket.get_ConnectedWebSocket()
   at System.Net.WebSockets.ClientWebSocket.SendAsync(ReadOnlyMemory`1 buffer, WebSocketMessageType messageType, Boolean endOfMessage, CancellationToken cancellationToken)
   at System.Net.WebSockets.WebSocketExtensions.SendAsync(WebSocket webSocket, ReadOnlySequence`1 buffer, WebSocketMessageType webSocketMessageType, CancellationToken cancellationToken) in /_/src/SignalR/common/Shared/WebSocketExtensions.cs:line 19
   at Microsoft.AspNetCore.Http.Connections.Client.Internal.WebSocketsTransport.StartSending(WebSocket socket, Boolean ignoreFirstCanceled) in /_/src/SignalR/clients/csharp/Http.Connections.Client/src/Internal/WebSocketsTransport.cs:line 562
===================
Raw output
   at Microsoft.AspNetCore.SignalR.Tests.VerifyNoErrorsScope.Dispose() in D:\a\_work\1\s\src\Shared\SignalR\VerifyNoErrorScope.cs:line 47
   at Microsoft.AspNetCore.SignalR.Tests.InProcessTestServer`1.DisposeAsync() in D:\a\_work\1\s\src\Shared\SignalR\InProcessTestServer.cs:line 161
   at Microsoft.AspNetCore.SignalR.Tests.InProcessTestServer`1.DisposeAsync() in D:\a\_work\1\s\src\Shared\SignalR\InProcessTestServer.cs:line 168
   at Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.ChangingUserNameDuringReconnectLogsWarning() in /_/src/SignalR/clients/csharp/Client/test/FunctionalTests/HubConnectionTests.cs:line 2748
--- End of stack trace from previous location ---

Check failure on line 1 in Microsoft.AspNetCore.Server.Kestrel.Tests.KestrelConfigurationLoaderTests.ConfigureEndpoint_CanLoadPemCertificates

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

Microsoft.AspNetCore.Server.Kestrel.Tests.KestrelConfigurationLoaderTests.ConfigureEndpoint_CanLoadPemCertificates

Test failed