Simplify QuickGrid OnRowClick rendering by removing conditional duplication#64621
Merged
javiercn merged 2 commits intojaviercn/quickgrid-row-click-eventfrom Dec 3, 2025
Merged
Conversation
Contributor
|
Greetings! You've submitted a PR that modifies code that is shared with https://github.com/dotnet/runtime . Please make sure you synchronize this code with the changes in that repo! |
…back Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on adding OnRowClick EventCallback to QuickGrid
Simplify QuickGrid OnRowClick rendering by removing conditional duplication
Dec 3, 2025
javiercn
added a commit
that referenced
this pull request
Dec 3, 2025
…cation (#64621) * Initial plan * Simplify RenderRow by removing if/else and coalescing OnRowClick callback Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com>
javiercn
added a commit
that referenced
this pull request
Dec 4, 2025
* Add OnRowClick EventCallback to QuickGrid This change adds an OnRowClick parameter to QuickGrid that allows users to handle row click events. When the OnRowClick delegate is set: - The row receives a 'row-clickable' CSS class - A cursor: pointer style is applied via scoped CSS - Clicking the row invokes the callback with the row item Fixes #44899 * Add OnRowClick EventCallback to QuickGrid (#64606) * Initial plan * Fix RowClassApplied test and consolidate RenderRow logic Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> * Fix trailing space in combinedClass when rowClass is null Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> * Simplify QuickGrid OnRowClick rendering by removing conditional duplication (#64621) * Initial plan * Simplify RenderRow by removing if/else and coalescing OnRowClick callback Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: javiercn <6995051+javiercn@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify QuickGrid OnRowClick rendering by removing conditional duplication
Address review feedback on QuickGrid OnRowClick implementation
Description
Addresses feedback from #64602 to simplify the
RenderRowmethod by removing duplicated<tr>element rendering.Changes:
OnRowClickcallback into a local variable usingEventCallback.Factory.Createif/elseblock that duplicated the entire<tr>element@onclickto the row—RenderTreeBuilder.AddAttributealready elides the attribute when the callback has no delegateFixes #64602
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.