[release/10.0] Get rid of package baseline #64337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
added
* NO MERGE *
wtgodbe
changed the title
Copilot finished reviewing on behalf of
wtgodbe
November 13, 2025 00:21
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the package baseline infrastructure from the ASP.NET Core repository. The baseline system was previously used to ensure consistent package dependencies across servicing builds by tracking the last RTM release versions and preventing breaking changes to package dependencies.
Key Changes:
- Removed the BaselineGenerator tool and all baseline validation logic from the build system
- Deleted baseline data files (Baseline.xml and Baseline.Designer.props)
- Updated documentation to remove references to baseline management
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| eng/tools/BaselineGenerator/* | Complete removal of the BaselineGenerator tool (Program.cs, .csproj, README.md) |
| eng/Baseline.xml | Deleted baseline input file containing package versions from previous release (9.0.0) |
| eng/Baseline.Designer.props | Deleted auto-generated MSBuild props file with baseline package references |
| eng/targets/ResolveReferences.targets | Removed baseline reference resolution logic, UnusedBaselinePackageReference checks, and servicing build error for changed references |
| eng/targets/Packaging.targets | Removed EnsureBaselineIsUpdated target that validated baseline currency |
| eng/scripts/CodeCheck.ps1 | Removed step to regenerate package baselines during code checks |
| Directory.Build.targets | Removed import of Baseline.Designer.props and logic to set versions based on baseline for non-patched packages in servicing builds |
| eng/Versions.props | Removed ValidateBaseline property |
| eng/Dependencies.props | Updated comment to remove reference to BaselinePackageReference items |
| src/Components/Components/src/Microsoft.AspNetCore.Components.csproj | Removed SuppressBaselineReference items and related documentation comments |
| eng/tools/tools.slnf | Removed BaselineGenerator project from solution filter |
| AspNetCore.slnx | Removed BaselineGenerator project from solution |
| docs/ReferenceResolution.md | Removed documentation about baseline files, SuppressBaselineReference usage, and breaking change examples |
| docs/PreparingPatchUpdates.md | Removed instructions to update package baselines when preparing patch updates |
| docs/UpdatingMajorVersionAndTFM.md | Removed step to update Baseline.xml after RTM ships |
wtgodbe
added
the
tell-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of package baseline, which is no longer needed (this code path never gets hit)