Skip to content

Enable Identity telemetry by instantiating metrics classes directly #64265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 7, 2025
Merged

Enable Identity telemetry by instantiating metrics classes directly #64265

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f99923e
Initial plan
Copilot Nov 6, 2025
f4aa956
Register UserManagerMetrics and SignInManagerMetrics in DI container
Copilot Nov 6, 2025
6eed689
Add InternalsVisibleTo and remove duplicate shared source files to en…
Copilot Nov 6, 2025
749b76d
Remove InternalsVisibleTo between product assemblies per feedback
Copilot Nov 6, 2025
bb2a007
Instantiate metrics classes directly instead of registering in DI
Copilot Nov 6, 2025
7b2ae04
Add AddMetrics() call when registering UserManager and SignInManager
Copilot Nov 7, 2025
756e4f0
Add test to verify metrics are recorded for UserManager and SignInMan…
Copilot Nov 7, 2025
4c4bb00
Update
JamesNK Nov 7, 2025
5bbe4f6
Update
JamesNK Nov 7, 2025
b6491f2
Update src/Identity/Extensions.Core/src/UserManager.cs
JamesNK Nov 7, 2025
5cb5b23
Update src/Identity/Core/src/SignInManager.cs
JamesNK Nov 7, 2025
2d6feec
Apply suggestion from @JamesNK
JamesNK Nov 7, 2025
11f51f7
Apply suggestion from @JamesNK
JamesNK Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Identity/Core/src/IdentityBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ private static void AddSignInManagerDeps(this IdentityBuilder builder)
builder.Services.AddScoped(typeof(ISecurityStampValidator), typeof(SecurityStampValidator<>).MakeGenericType(builder.UserType));
builder.Services.AddScoped(typeof(ITwoFactorSecurityStampValidator), typeof(TwoFactorSecurityStampValidator<>).MakeGenericType(builder.UserType));
builder.Services.TryAddEnumerable(ServiceDescriptor.Singleton<IPostConfigureOptions<SecurityStampValidatorOptions>, PostConfigureSecurityStampValidatorOptions>());
builder.Services.TryAddSingleton<SignInManagerMetrics>();
}

/// <summary>
Expand Down
2 changes: 2 additions & 0 deletions src/Identity/Core/src/IdentityServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ public static class IdentityServiceCollectionExtensions
services.TryAddScoped<IUserClaimsPrincipalFactory<TUser>, UserClaimsPrincipalFactory<TUser, TRole>>();
services.TryAddScoped<IUserConfirmation<TUser>, DefaultUserConfirmation<TUser>>();
services.TryAddScoped<IPasskeyHandler<TUser>, PasskeyHandler<TUser>>();
services.TryAddSingleton<UserManagerMetrics>();
services.TryAddSingleton<SignInManagerMetrics>();
services.TryAddScoped<UserManager<TUser>>();
services.TryAddScoped<SignInManager<TUser>>();
services.TryAddScoped<RoleManager<TRole>>();
Expand Down
2 changes: 0 additions & 2 deletions src/Identity/Core/src/Microsoft.AspNetCore.Identity.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@

<ItemGroup>
<Compile Include="$(SharedSourceRoot)DefaultMessageEmailSender.cs" LinkBase="Shared" />
<Compile Include="$(SharedSourceRoot)Metrics\MetricsConstants.cs" LinkBase="Shared" />
<Compile Include="$(SharedSourceRoot)ValueStopwatch\ValueStopwatch.cs" LinkBase="Shared" />
</ItemGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Identity/Extensions.Core/src/IdentityServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public static IdentityBuilder AddIdentityCore<TUser>(this IServiceCollection ser
// No interface for the error describer so we can add errors without rev'ing the interface
services.TryAddScoped<IdentityErrorDescriber>();
services.TryAddScoped<IUserClaimsPrincipalFactory<TUser>, UserClaimsPrincipalFactory<TUser>>();
services.TryAddSingleton<UserManagerMetrics>();
services.TryAddScoped<UserManager<TUser>>();

if (setupAction != null)
Expand Down
1 change: 1 addition & 0 deletions src/Identity/Extensions.Core/src/Microsoft.Extensions.Identity.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
</ItemGroup>

<ItemGroup>
<InternalsVisibleTo Include="Microsoft.AspNetCore.Identity" />
Copy link
Member

@JamesNK JamesNK Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Is this required? We want to avoid adding InternalsVisibleTo between product assemblies.

Copy link
Contributor Author

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in 749b76d. Now only SignInManagerMetrics (which is in Core) is registered in Core's AddIdentity. UserManagerMetrics (which is in Extensions.Core) is only registered in Extensions.Core's AddIdentityCore.

<InternalsVisibleTo Include="Microsoft.AspNetCore.Identity.Specification.Tests" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Identity.Test" />
<InternalsVisibleTo Include="Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test" />
Expand Down
Loading