Skip to content

Add analyzer to prevent local functions accessing RenderTreeBuilder from parent scope in Blazor components #63826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add analyzer to prevent local functions accessing RenderTreeBuilder from parent scope in Blazor components #63826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
dadc728
Initial plan
Copilot Sep 25, 2025
37920ed
Add local function detection to RenderTreeBuilder analyzer
Copilot Sep 25, 2025
c972789
Complete implementation of local function detection in RenderTreeBuil…
Copilot Sep 25, 2025
36e3eba
Scope local function analysis to BuildRenderTree methods in Component…
Copilot Jan 26, 2026
cec9762
Merge main into ASP0029 analyzer branch
Copilot Aug 13, 2026
504b6b7
Merge current main for ASP0039 analyzer
Copilot Aug 13, 2026
90f043e
Restore submodule pointers from main
Copilot Aug 13, 2026
83ca217
Modernize captured RenderTreeBuilder analyzer
Copilot Aug 13, 2026
d774c50
Remove analyzer test trailing whitespace
Copilot Aug 13, 2026
a42cad4
Track owning RenderTreeBuilder provenance
Copilot Aug 13, 2026
b654ce5
Cover indirect ASP0039 provenance flows
Copilot Aug 13, 2026
c72149f
Fix ASP0039 loop provenance and Razor coverage
Copilot Aug 13, 2026
c3b90da
Handle ASP0039 loop branch provenance
Copilot Aug 13, 2026
c456130
Preserve terminating switch loop paths
Copilot Aug 13, 2026
0a53e1a
Fix ASP0039 return path provenance
Copilot Aug 14, 2026
afbb737
Clarify ASP0039 diagnostic title
Copilot Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/list-of-diagnostics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Analyzer Warnings

### ASP (`ASP0000-ASP0038`)
### ASP (`ASP0000-ASP0039`)

| Diagnostic ID | Description |
| :---------------- | :---------- |
Expand Down Expand Up @@ -44,6 +44,7 @@
| __`ASP0036`__ | Validatable property or its type on an endpoint parameter type is not accessible |
| __`ASP0037`__ | \[ValidatableType] cannot be used in generated code |
| __`ASP0038`__ | \[ValidatableType] should not be used without a call to 'AddValidation' |
| __`ASP0039`__ | Do not access a captured RenderTreeBuilder from a local function |

### API (`API1000-API1003`)

Expand Down
8 changes: 8 additions & 0 deletions src/Framework/AspNetCoreAnalyzers/src/Analyzers/DiagnosticDescriptors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,14 @@ internal static class DiagnosticDescriptors
DiagnosticSeverity.Info,
isEnabledByDefault: true);

internal static readonly DiagnosticDescriptor DoNotUseLocalFunctionsInMarkup = CreateDiagnosticDescriptor(
"ASP0039",
CreateLocalizableResourceString(nameof(Resources.Analyzer_DoNotUseLocalFunctionsInMarkup_Title)),
CreateLocalizableResourceString(nameof(Resources.Analyzer_DoNotUseLocalFunctionsInMarkup_Message)),
Usage,
Comment thread
PureWeen marked this conversation as resolved.
DiagnosticSeverity.Error,
isEnabledByDefault: true);

private static DiagnosticDescriptor CreateDiagnosticDescriptor(
string id,
LocalizableString title,
Expand Down
Loading
Loading