Skip to content

Get native .pdb into Shared Framework symbol package #62124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Get native .pdb into Shared Framework symbol package #62124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc9f11
Get native .pdb into Shared Framework symbol package
wtgodbe May 27, 2025
409d2c8
New approach
wtgodbe May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.Composite.sfxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@
<AllowedReferenceRelatedFileExtensions>.pdb</AllowedReferenceRelatedFileExtensions>

<PartialCompositeAssemblyListPath>PartialCompositeAssemblyListPath.txt</PartialCompositeAssemblyListPath>

<GetSharedFrameworkFilesForReadyToRunDependsOn>
$(GetSharedFrameworkFilesForReadyToRunDependsOn);
_ResolveCopyLocalNativeReference;
</GetSharedFrameworkFilesForReadyToRunDependsOn>
</PropertyGroup>

<ItemGroup>
Expand Down Expand Up @@ -84,6 +89,11 @@
Include="$(ArtifactsBinDir)InProcessRequestHandler\$(NativePlatform)\$(Configuration)\aspnetcorev2_inprocess.dll" />
</ItemGroup>

<Target Name="_ResolveCopyLocalNativeReference">
<ItemGroup>
<ReferenceCopyLocalPaths Include="@(NativeRuntimeAsset)" />
</ItemGroup>
</Target>

<Target Name="_WarnAboutUnbuiltNativeDependencies"
BeforeTargets="Build"
Expand Down
10 changes: 10 additions & 0 deletions src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.sfxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@

<!-- TODO: Try to remove this disable property -->
<DisablePackageReferenceRestrictions>true</DisablePackageReferenceRestrictions>

<GetSharedFrameworkFilesForReadyToRunDependsOn>
$(GetSharedFrameworkFilesForReadyToRunDependsOn);
_ResolveCopyLocalNativeReference;
</GetSharedFrameworkFilesForReadyToRunDependsOn>
</PropertyGroup>

<PropertyGroup Condition="'$(BuildInstallers)' == 'true' or '$(TargetOsName)' == 'win'">
Expand Down Expand Up @@ -81,6 +86,11 @@
Include="$(ArtifactsBinDir)InProcessRequestHandler\$(NativePlatform)\$(Configuration)\aspnetcorev2_inprocess.dll" />
</ItemGroup>

<Target Name="_ResolveCopyLocalNativeReference">
<ItemGroup>
<ReferenceCopyLocalPaths Include="@(NativeRuntimeAsset)" />
</ItemGroup>
</Target>

<Target Name="_WarnAboutUnbuiltNativeDependencies"
BeforeTargets="Build"
Expand Down
Loading