Fix sanitization of type names in validations generator #61952
Conversation
github-actions
bot
added
the
needs-area-label
captainsafia
added
area-minimal
| ] | ||
| ); | ||
| } | ||
| private ValidatableTypeInfo CreateDictionary_2() |
There was a problem hiding this comment.
#61953 will change how this looks but we validate that compilable names are emitted here.
| .Replace(",", "_") | ||
| .Replace(" ", "_"); | ||
| // Replace invalid characters with underscores | ||
| return InvalidNameCharsRegex.Replace(typeName, "_"); |
There was a problem hiding this comment.
It can't start with a digit presumably?
There was a problem hiding this comment.
I don't think there's a restriction on metadata names starting with digits per the CLR spec. However, since we derive this MetadataName that we pass to this method from a TypeSymbol resolve via static analysis, it's probably come from C# code where an identifier starting with a number is invalid.
If we do hit that case, I think emitting a method name starting with _ is OK syntax so the generator shouldn't emit invalid syntax.
|
Gonna merge this so it lands before the preview.5 cut-off. Happy to address feedback after merge in a follow-up PR. |
This pull request introduces several updates to the
ValidationsGeneratorin theMicrosoft.AspNetCore.Httpproject, focusing on improving type name sanitization.SanitizeTypeNamewith a compiledRegex(InvalidNameCharsRegex) for improved clarity and maintainability. (src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.ValidationsGenerator/Emitters/ValidationsGenerator.Emitter.cs, [1] [2]Fixes #61388.
Note: I realize that as a follow-up to this change we need to make updates to the implementation to support validating dictionary values. Since that's a bit more involved I'll pull it out into a separate PR.