Skip to content

Fix Dependency Injection Conflict with Null Parameter in SignalR Hub Methods #61687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 28, 2025
Merged

Fix Dependency Injection Conflict with Null Parameter in SignalR Hub Methods #61687

merged 5 commits into from
Apr 28, 2025

Conversation

@MohabASHRAF-byte
Copy link
Contributor

@MohabASHRAF-byte MohabASHRAF-byte commented Apr 25, 2025

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making.

Summary of the changes

  • Check if service exists before use
  • Add test for the case

Fixes #61491

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Apr 25, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 25, 2025
@MohabASHRAF-byte
Copy link
Contributor Author

MohabASHRAF-byte commented Apr 25, 2025

@dotnet-policy-service agree

@build-analysis build-analysis bot mentioned this pull request Apr 25, 2025
Closed
3 tasks
BrennanConroy
BrennanConroy reviewed Apr 28, 2025
View reviewed changes
@BrennanConroy BrennanConroy merged commit 857e35f into dotnet:main Apr 28, 2025
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview5 milestone Apr 28, 2025
@BrennanConroy
Copy link
Member

BrennanConroy commented Apr 28, 2025

Thanks for the PR @MohabASHRAF-byte !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

+1 more reviewer

@gfoidl gfoidl gfoidl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-signalr Includes: SignalR clients and servers community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

10.0-preview5

Development

Successfully merging this pull request may close these issues.

Dependency Injection Conflict with Null Parameter in SignalR Hub Methods

3 participants

@MohabASHRAF-byte @BrennanConroy @gfoidl